From: Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Samuel Bronson <naesten-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dwarves <dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: pahole regression: -a no longer works?
Date: Sat, 27 Jun 2009 12:50:57 -0300 [thread overview]
Message-ID: <20090627155057.GA3349@ghostprotocols.net> (raw)
In-Reply-To: <87eit5lm0u.wl%naesten-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Em Sat, Jun 27, 2009 at 11:44:01AM -0400, Samuel Bronson escreveu:
> Oops, I sent this to just Arnaldo the first time... sorry, Arnaldo!
>
> On Sat, Jun 27, 2009 at 10:44 AM, Arnaldo Carvalho de
> Melo<acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org> wrote:
>
> > What about my suggestion to change the proposed patch to check if it is
> > running on a debian system and if so to avoid checking for libebl?
>
> Well, that wouldn't really help me with the bisection, though now that
I see, you would have to apply the patch at each bisection point and
remove it before going forward...
But anyway, you don't need to bisect it now, I've fixed it already :)
Please do a git pull and check if everything is ok now.
> I think about it I could have done that on one of the machines in my
> school's CS lab, where I had to build the elfutils libraries myself
> anyway...
> Anyway, about that idea: Debian hasn't always lacked libebl -- rolling
> it into libdw is a fairly recent thing, and back when it existed, both
> libdw and libebl were provided as static libraries, so on systems
> that still have it, it will probably be necessary to link it in. Not
> to mention that having to conditionalize this on the distribution
> feels kind of icky, especially considering how hard-to-follow the
> REDHAT/FEDORA conditional already is.
>
> Speaking of the REDHAT/FEDORA conditional,
>
> (a) why doesn't it have a comment explaining what it's for? -- that
> is, what is different on redhat/fedora, and what it does to compensate
> for them
I'll add the comment now
> (b) why is it *after* the check for the "dwfl_module_build_id"
> symbol, so that the REDHAT/FEDORA stuff can't fix up the missing
> variables and allow the symbol check a chance to run?
lemme check...
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-06-27 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 1:29 pahole regression: -a no longer works? Samuel Bronson
[not found] ` <20090627144405.GE4981@ghostprotocols.net>
[not found] ` <20090627144405.GE4981-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-06-27 15:44 ` Samuel Bronson
[not found] ` <87eit5lm0u.wl%naesten-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-06-27 15:50 ` Arnaldo Carvalho de Melo [this message]
2009-06-27 16:34 ` Arnaldo Carvalho de Melo
2009-06-27 15:36 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090627155057.GA3349@ghostprotocols.net \
--to=acme-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=naesten-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).