Dwarves Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] pahole: fix maybe-uninitialized and rpm build
@ 2020-01-17  0:59 Yulia Kartseva
       [not found] ` <cover.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Yulia Kartseva @ 2020-01-17  0:59 UTC (permalink / raw)
  To: dwarves-u79uwXL29TY76Z2rM5mHXA, acme-DgEjT+Ai2ygdnm+yROfE0A
  Cc: Julia Kartseva, andriin-b10kYP2dOMg

From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>

Fix issues encountered while builing RPM w/ v1.16:
- maybe uninitialized variable in ‘pahole_stealer' function
- malformed date in dwarves.spec changelog causing rpm build failure

Arnaldo, I wonder if we can have v1.16 package bump in the distros sooner?
Thanks!

Julia Kartseva (2):
  pahole: fix compiler warning
  pahole: fix changelog date in dwarves.spec

 pahole.c               | 2 +-
 rpm/SPECS/dwarves.spec | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] pahole: fix compiler warning
       [not found] ` <cover.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
@ 2020-01-17  0:59   ` Yulia Kartseva
       [not found]     ` <d0b9a8c3bd459fb41f9b4dfb80d5a5972b5c2949.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
  2020-01-17  0:59   ` [PATCH 2/2] pahole: fix changelog date in dwarves.spec Yulia Kartseva
  1 sibling, 1 reply; 5+ messages in thread
From: Yulia Kartseva @ 2020-01-17  0:59 UTC (permalink / raw)
  To: dwarves-u79uwXL29TY76Z2rM5mHXA, acme-DgEjT+Ai2ygdnm+yROfE0A,
	hex-b10kYP2dOMg

From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>

Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
---
 pahole.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pahole.c b/pahole.c
index 829c9ab..7ac49c2 100644
--- a/pahole.c
+++ b/pahole.c
@@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
 	uint32_t id;
 
 	cu__for_each_struct_or_union(cu, id, pos) {
+		struct structure *str = NULL;
 		bool looked = false;
-		struct structure *str;
 
 		if (pos->type.namespace.name == 0)
 			continue;
-- 
2.17.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] pahole: fix changelog date in dwarves.spec
       [not found] ` <cover.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
  2020-01-17  0:59   ` [PATCH 1/2] pahole: fix compiler warning Yulia Kartseva
@ 2020-01-17  0:59   ` Yulia Kartseva
       [not found]     ` <e454b36160ba6cdc0fede26ca2ee8fe15314ae99.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
  1 sibling, 1 reply; 5+ messages in thread
From: Yulia Kartseva @ 2020-01-17  0:59 UTC (permalink / raw)
  To: dwarves-u79uwXL29TY76Z2rM5mHXA, acme-DgEjT+Ai2ygdnm+yROfE0A,
	hex-b10kYP2dOMg

From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>

Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
---
 rpm/SPECS/dwarves.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rpm/SPECS/dwarves.spec b/rpm/SPECS/dwarves.spec
index 82cb971..6155608 100644
--- a/rpm/SPECS/dwarves.spec
+++ b/rpm/SPECS/dwarves.spec
@@ -127,7 +127,7 @@ make install DESTDIR=%{buildroot}
 %{_libdir}/%{libname}_reorganize.so
 
 %changelog
-* Mon 16 Dec 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
+* Mon Dec 16 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
 - New release: 1.16
 - BTF encoder: Preserve and encode exported functions as BTF_KIND_FUNC.
 - BTF loader: Add support for BTF_KIND_FUNC
-- 
2.17.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] pahole: fix compiler warning
       [not found]     ` <d0b9a8c3bd459fb41f9b4dfb80d5a5972b5c2949.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
@ 2020-01-17 16:28       ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-01-17 16:28 UTC (permalink / raw)
  To: Yulia Kartseva; +Cc: dwarves-u79uwXL29TY76Z2rM5mHXA

Em Thu, Jan 16, 2020 at 04:59:12PM -0800, Yulia Kartseva escreveu:
> From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> 
> Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> ---
>  pahole.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pahole.c b/pahole.c
> index 829c9ab..7ac49c2 100644
> --- a/pahole.c
> +++ b/pahole.c
> @@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
>  	uint32_t id;
>  
>  	cu__for_each_struct_or_union(cu, id, pos) {
> +		struct structure *str = NULL;
>  		bool looked = false;
> -		struct structure *str;

I just fixed this one after trying to build it on RHEL7, thanks!

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=9b09f578b7d1e75cf168e9b3098d4fb17504f26e

- Arnaldo
  
>  		if (pos->type.namespace.name == 0)
>  			continue;
> -- 
> 2.17.1
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] pahole: fix changelog date in dwarves.spec
       [not found]     ` <e454b36160ba6cdc0fede26ca2ee8fe15314ae99.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
@ 2020-01-17 16:31       ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-01-17 16:31 UTC (permalink / raw)
  To: Yulia Kartseva; +Cc: dwarves-u79uwXL29TY76Z2rM5mHXA

Em Thu, Jan 16, 2020 at 04:59:13PM -0800, Yulia Kartseva escreveu:
> From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> 
> Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> ---
>  rpm/SPECS/dwarves.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied, my bad :-\

- Arnaldo
 
> diff --git a/rpm/SPECS/dwarves.spec b/rpm/SPECS/dwarves.spec
> index 82cb971..6155608 100644
> --- a/rpm/SPECS/dwarves.spec
> +++ b/rpm/SPECS/dwarves.spec
> @@ -127,7 +127,7 @@ make install DESTDIR=%{buildroot}
>  %{_libdir}/%{libname}_reorganize.so
>  
>  %changelog
> -* Mon 16 Dec 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
> +* Mon Dec 16 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
>  - New release: 1.16
>  - BTF encoder: Preserve and encode exported functions as BTF_KIND_FUNC.
>  - BTF loader: Add support for BTF_KIND_FUNC
> -- 
> 2.17.1
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17  0:59 [PATCH 0/2] pahole: fix maybe-uninitialized and rpm build Yulia Kartseva
     [not found] ` <cover.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
2020-01-17  0:59   ` [PATCH 1/2] pahole: fix compiler warning Yulia Kartseva
     [not found]     ` <d0b9a8c3bd459fb41f9b4dfb80d5a5972b5c2949.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
2020-01-17 16:28       ` Arnaldo Carvalho de Melo
2020-01-17  0:59   ` [PATCH 2/2] pahole: fix changelog date in dwarves.spec Yulia Kartseva
     [not found]     ` <e454b36160ba6cdc0fede26ca2ee8fe15314ae99.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
2020-01-17 16:31       ` Arnaldo Carvalho de Melo

Dwarves Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dwarves/0 dwarves/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dwarves dwarves/ https://lore.kernel.org/dwarves \
		dwarves@vger.kernel.org
	public-inbox-index dwarves

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dwarves


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git