Dwarves Archive on lore.kernel.org
 help / color / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Hao Luo <haoluo@google.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	daniel@iogearbox.net, dwarves@vger.kernel.org, yhs@fb.com
Subject: Re: [PATCH v2 0/2] pahole: Make encoding percpu vars into BTF optional.
Date: Mon, 21 Sep 2020 16:56:53 -0300
Message-ID: <20200921195653.GK1996959@kernel.org> (raw)
In-Reply-To: <20200921195310.3070085-1-haoluo@google.com>

Em Mon, Sep 21, 2020 at 12:53:08PM -0700, Hao Luo escreveu:
> v1 -> v2:
>  - Use opt-out instead of opt-in. Rename the flag name to
>    '--skip_encoding_btf_vars'
> Previous commit f3d9054ba8ff ("btf_encoder: Teach pahole to store
> percpu variables in vmlinux BTF.") introduced a feature in btf_encoder
> that encodes global symbols in BTF. However, this feature is not
> protected by any flag. In order to avoid surprises after Pahole v1.18
> rolls out, add a flag to toggle this feature off.
> Also as a refactor, introduce '--btf_encode_force' to replace the
> old '--force' and '-j' option that is used to forcefully emit BTF.
> Hao Luo (2):
>   btf_encoder: Allow disabling BTF var encoding.
>   btf_encoder: Introduce option '--btf_encode_force'
>  btf_encoder.c |  5 ++++-
>  btf_encoder.h |  3 ++-
>  pahole.c      | 22 +++++++++++++++++-----
>  3 files changed, 23 insertions(+), 7 deletions(-)
> -- 

You forgot to update the man page, I'll do it this time,


- Arnaldo

  parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 19:53 Hao Luo
2020-09-21 19:53 ` [PATCH v2 1/2] btf_encoder: Allow disabling BTF var encoding Hao Luo
2020-09-21 19:53 ` [PATCH v2 2/2] btf_encoder: Introduce option '--btf_encode_force' Hao Luo
2020-09-21 19:56 ` Arnaldo Carvalho de Melo [this message]
2020-09-21 20:00   ` [PATCH v2 0/2] pahole: Make encoding percpu vars into BTF optional Hao Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921195653.GK1996959@kernel.org \
    --to=acme@kernel.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dwarves@vger.kernel.org \
    --cc=haoluo@google.com \
    --cc=yhs@fb.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Dwarves Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dwarves/0 dwarves/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dwarves dwarves/ https://lore.kernel.org/dwarves \
	public-inbox-index dwarves

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git