From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Bronson Subject: Re: pahole regression: -a no longer works? Date: Sat, 27 Jun 2009 11:44:01 -0400 Message-ID: <87eit5lm0u.wl%naesten@gmail.com> References: <20090627144405.GE4981@ghostprotocols.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20090627144405.GE4981-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org> Sender: dwarves-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnaldo Carvalho de Melo Cc: dwarves List-Id: dwarves@vger.kernel.org Oops, I sent this to just Arnaldo the first time... sorry, Arnaldo! On Sat, Jun 27, 2009 at 10:44 AM, Arnaldo Carvalho de Melo wrote: > What about my suggestion to change the proposed patch to check if it is > running on a debian system and if so to avoid checking for libebl? Well, that wouldn't really help me with the bisection, though now that I think about it I could have done that on one of the machines in my school's CS lab, where I had to build the elfutils libraries myself anyway... Anyway, about that idea: Debian hasn't always lacked libebl -- rolling it into libdw is a fairly recent thing, and back when it existed, both libdw and libebl were provided as static libraries, so on systems that still have it, it will probably be necessary to link it in. Not to mention that having to conditionalize this on the distribution feels kind of icky, especially considering how hard-to-follow the REDHAT/FEDORA conditional already is. Speaking of the REDHAT/FEDORA conditional, (a) why doesn't it have a comment explaining what it's for? -- that is, what is different on redhat/fedora, and what it does to compensate for them (b) why is it *after* the check for the "dwfl_module_build_id" symbol, so that the REDHAT/FEDORA stuff can't fix up the missing variables and allow the symbol check a chance to run? -- To unsubscribe from this list: send the line "unsubscribe dwarves" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html