From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176D3C433E0 for ; Wed, 17 Feb 2021 18:03:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C528964E5B for ; Wed, 17 Feb 2021 18:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234768AbhBQSD1 (ORCPT ); Wed, 17 Feb 2021 13:03:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231856AbhBQSDT (ORCPT ); Wed, 17 Feb 2021 13:03:19 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 836AAC061574; Wed, 17 Feb 2021 10:02:38 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id q5so12072540ilc.10; Wed, 17 Feb 2021 10:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=9phedVN9F6tsus8Z4OUiJzjoyd9QAwQ4EHDKpiG4l0s=; b=fnCxuZNZZIc6MC70hCzch7AYMD5h3GIFy0f1Gs9xp8P06zb3/8axvzz97Ws7pDrH32 N71jDEdH0lz8uqNIWEQ9NnOoaCNeC4vcPop2FJwSSkAtYD/fwMJRdkhNVBuv6Hb9n5MI DVzUoS7yDybYsKCPEzBjQtEDqzxT+CjaNFXpWKWMABN4AerE05dTWspLJLW2+rkEoh8V /3n9uByJo5YZAKcEw9AAP9Zm7CD8o2zCez18CLNKyU3eaefi/DsxTBmUTo3m8mSu+iTI /afWQTHKzohD54Ev53cZgU04qB2pLPCoUrUPQltwTBT5EkmgOciGAraq51s7M5qufBi0 vovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=9phedVN9F6tsus8Z4OUiJzjoyd9QAwQ4EHDKpiG4l0s=; b=UwcDK9vqOI9Vjz4Ny2NHeMc1qLwETvELA6fIcbyV3lwSG6tlSN6VA1el3GFVyIuBg2 NMRPot2MLNgkuOGBb7HydIJMTDDsO59NigNc+mTWBO7nRkejSaTftZeEyqsFDHBtoBQh gzyxkoZZWHyLNN9cLO7wUaBRa2jj9GjSwxKVW9y+fDQT1mwYF1pGUC6y9MgPGM4k64G0 uwQKHssHXFwMhCsfFpQT1tu7RKjKgon1e/GmX6hTPBQ9buScH1sSIZ70QaXNohMS2b5L FJZsQlDr+RbHAbjbDFC/36vFMSaxef6kaKH/aR13eVUerPjYSuSkp/WXLpc4a+QBPgnf NE2g== X-Gm-Message-State: AOAM533eccWz63Suy7rSJLEry/b/7V85FrDcu+Mq5rTGmI2h1lIwMNy7 cnl75wWU7y+8t7gJ64lcTDCxcyanOQB9x0r/W20= X-Google-Smtp-Source: ABdhPJwQKEnLco30SxSgg73i0bPN5PocjhgmOHX6ErxX1rDT9y7StNtXtxFR7NIi4J4VsFr0wO7fq+ekk9ttWnlMwkw= X-Received: by 2002:a92:d8c5:: with SMTP id l5mr210279ilo.209.1613584957842; Wed, 17 Feb 2021 10:02:37 -0800 (PST) MIME-Version: 1.0 References: <20210213164648.1322182-1-jolsa@kernel.org> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Wed, 17 Feb 2021 19:02:26 +0100 Message-ID: Subject: Re: [PATCHv2] btf_encoder: Match ftrace addresses within elf functions To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Andrii Nakryiko , dwarves@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Yonghong Song , Hao Luo , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: dwarves@vger.kernel.org On Wed, Feb 17, 2021 at 2:56 PM Arnaldo Carvalho de Melo wrote: > > > > On February 17, 2021 10:40:43 AM GMT-03:00, Sedat Dilek wrote: > >On Wed, Feb 17, 2021 at 1:44 PM Arnaldo Carvalho de Melo > > wrote: > >> > >> Em Sat, Feb 13, 2021 at 05:46:48PM +0100, Jiri Olsa escreveu: > >> > Currently when processing DWARF function, we check its entrypoint > >> > against ftrace addresses, assuming that the ftrace address matches > >> > with function's entrypoint. > >> > > >> > This is not the case on some architectures as reported by Nathan > >> > when building kernel on arm [1]. > >> > > >> > Fixing the check to take into account the whole function not > >> > just the entrypoint. > >> > > >> > Most of the is_ftrace_func code was contributed by Andrii. > >> > >> Applied locally, will go out after tests, > >> > > > >Hi Arnaldo, > > > >Is it possible to have a pahole version 1.21 with this patch and the > >one from Yonghong Son? > > > >From my local pahole Git: > > > >$ git log --oneline --no-merges v1.20.. > >2f83aefdbddf (for-1.20/btf_encoder-ftrace_elf-clang-jolsa-v2) > >btf_encoder: Match ftrace addresses within elf functions > >f21eafdfc877 (for-1.20/btf_encoder-sanitized_int-clang-yhs-v2) > >btf_encoder: sanitize non-regular int base type > > > >Both patches fixes all issues seen so far with LLVM/Clang >= > >12.0.0-rc1 and DWARF-v5 and BTF (debug-info) and pahole on > >Linux/x86_64 and according to Nathan on Linux/arm64. > >Yesterday, I tried with LLVM/Clang 13-git from . > > > >BTW, Nick's DWARF-v5 patches are pending in (see > >[1]). > > > >Personally, I can wait until [1] is in Linus Git. > > > >Please, let me/us know what you are planning. > >( I know it is Linux v5.12 merge-window. ) > > Sure, next week. > That's OK with me. - Sedat - > - Arnaldo > > > > >Regards, > >- Sedat - > > > >[1] > >https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=kbuild > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity.