From: Andrii Nakryiko <email@example.com> To: Arnaldo Carvalho de Melo <firstname.lastname@example.org> Cc: bpf <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: latest pahole breaks libbpf CI and let's talk about staging Date: Wed, 16 Jun 2021 10:40:45 -0700 [thread overview] Message-ID: <CAEf4BzZ7KDcsViCY8MbUZuWu2BdkjymkgJtyVUMBrCaiimUCxQ@mail.gmail.com> (raw) In-Reply-To: <YMoRBvTdD0qzjYf4@kernel.org> On Wed, Jun 16, 2021 at 7:56 AM Arnaldo Carvalho de Melo <firstname.lastname@example.org> wrote: > > Em Tue, Jun 15, 2021 at 04:30:03PM -0700, Andrii Nakryiko escreveu: > > Hey Arnaldo, > > > > Seems like de3a7f912559 ("btf_encoder: Reduce the size of encode_cu() > > by moving function encoding to separate method") break two selftests > > in libbpf CI (see ). Please take a look. I suspect some bad BTF, > > because both tests rely on kernel BTF info. > > > > You've previously asked about staging pahole changes. Did you make up > > your mind about branch names and the process overall? Seems like a > > good chance to bring this up ;-P > > > >  https://travis-ci.com/github/libbpf/libbpf/jobs/514329152 > > Ok, please add tmp.master as the staging branch, I'll move things to > master only after it passing thru CI. > So I'm thinking about what's the best setup to catch pahole staging problems, but not break main libbpf CI and kernel-patches CI flows. How about we keep all the existing CI jobs to use pahole's master. Then add a separate job to do full kernel build with pahole built from staging branch. And mark it as non-critical (or whatever the terminology), so it doesn't mark the build red. I'd do that as a cron job that runs every day. That way if you don't have anything urgent, next day you'll get staging tested automatically. If you need to test right now, there is a way to re-trigger previous build and it will re-fetch latest staging (so there is a way for you to proactively test). Basically, I want broken staging pahole to not interrupt anything we are doing. WDYT? > Now looking at that code, must be something subtle... > > - Arnaldo
next prev parent reply other threads:[~2021-06-16 17:40 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-15 23:30 Andrii Nakryiko 2021-06-16 14:56 ` Arnaldo Carvalho de Melo 2021-06-16 16:40 ` Arnaldo Carvalho de Melo 2021-06-16 20:41 ` Arnaldo Carvalho de Melo 2021-06-16 22:36 ` Andrii Nakryiko 2021-06-17 14:48 ` Arnaldo Carvalho de Melo 2021-06-17 19:53 ` Arnaldo Carvalho de Melo 2021-06-17 20:03 ` Andrii Nakryiko 2021-06-17 20:41 ` Arnaldo Carvalho de Melo 2021-06-17 21:56 ` Andrii Nakryiko 2021-06-17 20:00 ` Andrii Nakryiko 2021-06-17 20:39 ` Arnaldo Carvalho de Melo 2021-06-17 21:52 ` Andrii Nakryiko 2021-06-18 17:21 ` Arnaldo Carvalho de Melo 2021-06-16 17:40 ` Andrii Nakryiko [this message] 2021-06-16 18:25 ` Arnaldo Carvalho de Melo 2021-06-16 22:38 ` Andrii Nakryiko 2021-06-17 0:16 ` Arnaldo Carvalho de Melo 2021-06-17 4:26 ` Andrii Nakryiko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAEf4BzZ7KDcsViCY8MbUZuWu2BdkjymkgJtyVUMBrCaiimUCxQ@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: latest pahole breaks libbpf CI and let'\''s talk about staging' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).