Re: [PATCH] pahole: correct libbpf git url

[Andrii Nakryiko <andrii.nakryiko@gmail.com>]

On Fri, Aug 6, 2021 at 11:42 AM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Fri, Aug 06, 2021 at 06:12:43PM +0800, Joseph Qi escreveu:
> > Otherwise it will encounter the following error:
> > fatal: unable to access 'https://github.com/libbpf/libbpf/': Encountered end of file
> > fatal: clone of 'https://github.com/libbpf/libbpf' into submodule path '/home/workspace/pahole/lib/bpf' failed
> >
> > Also update README to add step 'make'.
>
> You forgot to add Andrii, the author of the patch you're fixing, to the
> CC list, please do it next time.

Heh, thanks! Don't worry, I'm subscribed to dwarves@vger, so I saw this anyways.

>
> - Arnaldo
>
> > Fixes: 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf")
> > Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> > ---
> >  .gitmodules | 2 +-
> >  README      | 3 ++-
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/.gitmodules b/.gitmodules
> > index 6be99dc..8be5eb6 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -1,3 +1,3 @@
> >  [submodule "lib/bpf"]
> >       path = lib/bpf
> > -     url = https://github.com/libbpf/libbpf
> > +     url = https://github.com/libbpf/libbpf.git

This doesn't hurt, but as Arnaldo pointed out, it seems to work just
fine as is. Not sure how you ran into this problem... And why did it
append the final '/' (still don't know if that's the reason)?

> > diff --git a/README b/README
> > index c9f1737..07f5876 100644
> > --- a/README
> > +++ b/README
> > @@ -4,7 +4,8 @@ Build instructions:
> >  2. mkdir build
> >  3. cd build
> >  4. cmake -D__LIB=lib ..
> > -5. make install
> > +5. make
> > +6. make install

Doesn't make install imply the build as well?


> >
> >  cmake Options:
> >    -DBUILD_SHARED_LIBS
> > --
> > 1.8.3.1
> >
>
> --
>
> - Arnaldo