From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo <arnaldo.melo@gmail.com>
Cc: Shuyi Cheng <chengshuyi@linux.alibaba.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
dwarves@vger.kernel.org, wenan.mao@linux.alibaba.com,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v2] pahole: Add --kabi_prefix flag
Date: Wed, 19 May 2021 23:18:14 +0200 [thread overview]
Message-ID: <YKWAlm5KO4S9HBmn@krava> (raw)
In-Reply-To: <5D76A4F3-6F5A-4061-A274-34FFE5CBA338@gmail.com>
On Wed, May 19, 2021 at 05:23:31PM -0300, Arnaldo wrote:
>
>
> On May 19, 2021 5:07:03 PM GMT-03:00, Jiri Olsa <jolsa@redhat.com> wrote:
> >On Wed, May 19, 2021 at 10:44:44AM +0800, Shuyi Cheng wrote:
> >> To solve problems similar to _RH_KABI_REPLACE. The
> >_RH_KABI_REPLACE(_orig,
> >> _new) macros perserve size alignment and kabi agreement between _orig
> >and
> >> _new.Below is the definition of this macro:
> >>
> >> # define _RH_KABI_REPLACE(_orig, _new) \
> >> union { \
> >> _new; \
> >> struct { \
> >> _orig; \
> >> } __UNIQUE_ID(rh_kabi_hide); \
> >> __RH_KABI_CHECK_SIZE_ALIGN(_orig, _new); \
> >> }
> >
> >hi,
> >that macro sounds familiar ;-) I think this should be already
> >solved directly in the header file by this one:
> >
> >https://gitlab.com/cki-project/kernel-ark/-/commit/331be9c5a436057ee852075c102d9d90a9046a30
> >
>
> But this means newer kernels will not have that issue, so perhaps we should just document this?
I don't think there's released kernel with this issue
>
> Or would it be worth the effort of having a --ignore_prefix option for the people using all the kernels where this is applicable to and leave the option lingering there just in case?
this is specific to rh kernels and fixed by that patch above,
I wouldn't expect seeing it again
jirka
next prev parent reply other threads:[~2021-05-19 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 12:06 [PATCH] btf: Add --btf_prefix flag 程书意
2021-05-17 14:42 ` Arnaldo Carvalho de Melo
2021-05-18 9:02 ` chengshuyi
2021-05-18 12:49 ` Arnaldo Carvalho de Melo
2021-05-18 18:30 ` Andrii Nakryiko
2021-05-19 2:44 ` [PATCH v2] pahole: Add --kabi_prefix flag Shuyi Cheng
2021-05-19 20:07 ` Jiri Olsa
[not found] ` <5D76A4F3-6F5A-4061-A274-34FFE5CBA338@gmail.com>
2021-05-19 21:18 ` Jiri Olsa [this message]
2021-05-19 21:36 ` Arnaldo
2021-05-20 10:27 ` Shuyi Cheng
2021-05-20 11:49 ` Jiri Olsa
2021-05-20 12:08 ` Shuyi Cheng
2021-05-20 12:18 ` Jiri Olsa
2021-05-20 12:30 ` Shuyi Cheng
2021-05-20 15:25 ` Jiri Olsa
2021-05-21 1:44 ` [PATCH v3] " Shuyi Cheng
2021-05-27 16:43 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKWAlm5KO4S9HBmn@krava \
--to=jolsa@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=chengshuyi@linux.alibaba.com \
--cc=dwarves@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=wenan.mao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).