dwarves.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Luca Boccassi <bluca@debian.org>,
	dwarves@vger.kernel.org,
	Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Subject: Re: [PATCH dwarves] Add missing lib/include/bpf -> ../bpf/src symlink
Date: Sun, 13 Jun 2021 10:27:40 -0300	[thread overview]
Message-ID: <YMYHzGplz+p6UJgx@kernel.org> (raw)
In-Reply-To: <CAEf4BzYTSd1PvreyK8gsdL6=XPPqELQpz7DYAc-B=cH7L0QDKQ@mail.gmail.com>

Em Fri, Jun 11, 2021 at 04:42:24PM -0700, Andrii Nakryiko escreveu:
> Locally I have still another issue, which I don't believe is related
> to Luca's changes. I get this error:
> 
> $ make -j60
> [ 25%] Built target bpf
> [ 26%] Building C object CMakeFiles/dwarves.dir/btf_encoder.c.o
> In file included from /usr/include/sys/stat.h:106:0,
>                  from /home/andriin/local/pahole/btf_encoder.c:24:
> /usr/include/bits/stat.h:106:31: error: expected identifier or ‘(’
> before ‘[’ token
>      __syscall_slong_t __unused[3];
>                                ^
> /usr/include/bits/stat.h:164:31: error: expected identifier or ‘(’
> before ‘[’ token
>      __syscall_slong_t __unused[3];
>                                ^
> make[2]: *** [CMakeFiles/dwarves.dir/btf_encoder.c.o] Error 1
> make[1]: *** [CMakeFiles/dwarves.dir/all] Error 2
> make: *** [all] Error 2
> 
> 
> I think it's some new interplay with dutil.h header defining its own
> 
> #define __unused __attribute__ ((unused))
> 
> Given __unused is used in vmlinux.h and /usr/include/bits/stat.h as
> field names, I think it would be better to rename __unused macro
> within pahole source code to avoid such confusing problems.

I'll fix this adopting the kernel __maybe_unused jargon.

- Arnaldo

      parent reply	other threads:[~2021-06-13 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 23:01 [PATCH dwarves] Add missing lib/include/bpf -> ../bpf/src symlink Luca Boccassi
2021-06-11 23:42 ` Andrii Nakryiko
2021-06-13 13:14   ` Arnaldo Carvalho de Melo
2021-06-13 13:17     ` Arnaldo Carvalho de Melo
2021-06-13 13:21     ` Arnaldo Carvalho de Melo
2021-06-13 13:27   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMYHzGplz+p6UJgx@kernel.org \
    --to=acme@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=bluca@debian.org \
    --cc=dwarves@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).