dwarves.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Luca Boccassi <bluca@debian.org>
Cc: Frank Heckenbach <f.heckenbach@fh-soft.de>, dwarves@vger.kernel.org
Subject: Re: pahole: Problems with lib/include/bpf symlink in a tarball with --transform
Date: Thu, 12 Aug 2021 21:05:29 -0300	[thread overview]
Message-ID: <YRW3SRQtoOtEyUem@kernel.org> (raw)
In-Reply-To: <CAMw=ZnSkjDrvKtzcySn5TXoTwdfnkMe5FrUKidZdpFV87jhTAw@mail.gmail.com>

Em Thu, Aug 12, 2021 at 10:50:00PM +0100, Luca Boccassi escreveu:
> On Thu, 12 Aug 2021 at 20:06, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Thu, Aug 12, 2021 at 04:00:38PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > [acme@seventh pahole]$ ls -la dwarves-1.22/lib/include/
> > > total 8
> > > drwxr-xr-x. 2 acme acme 4096 Aug 12 15:54 .
> > > drwxr-xr-x. 4 acme acme 4096 Aug 12 15:54 ..
> > > lrwxrwxrwx. 1 acme acme   23 Jun 18 17:56 bpf -> dwarves-1.22/../bpf/src
> > > [acme@seventh pahole]$

> > Ok, including the parent directory and then replacing it with the
> > desired package_name-package_version did the trick ;-)

> > ⬢[acme@toolbox pahole]$ v=1.$(($(git tag | sort -V | tail -1 | cut -d. -f2) + 1)) ; tar cvfJ ~/rpmbuild/SOURCES/dwarves-${v}.tar.xz --transform "s,^pahole/,dwarves-${v}/," `sed s%^%../pahole/%g MANIFEST`
> > ⬢[acme@toolbox pahole]$ tar tvf ~/rpmbuild/SOURCES/dwarves-1.22.tar.xz  | tail
> > -rw-r--r-- acme/acme       252 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/helpers.sh
> > -rwxr-xr-x acme/acme      3084 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/mkrootfs.sh
> > -rwxr-xr-x acme/acme        86 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/prepare_selftests-4.9.0.sh
> > -rwxr-xr-x acme/acme        86 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/prepare_selftests-5.5.0.sh
> > -rwxr-xr-x acme/acme       365 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/prepare_selftests.sh
> > -rwxr-xr-x acme/acme     10841 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/run.sh
> > -rwxr-xr-x acme/acme      1245 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/run_selftests.sh
> > -rwxr-xr-x acme/acme      1132 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/run_vmtest.sh
> > -rw-r--r-- acme/acme   2904227 2021-06-14 15:51 dwarves-1.22/lib/bpf/travis-ci/vmtest/vmlinux.h
> > lrwxrwxrwx acme/acme         0 2021-08-11 08:55 dwarves-1.22/lib/include/bpf -> ../bpf/src
> > ⬢[acme@toolbox pahole]$

> > yeah, it now builds from the generated tarball, updating README.tarball 8-)
 
> Glad to hear you found a fix - I would have had no idea :-)

Now you have, but hopefully will forget about it soon. At least we have
this in place:

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?h=next&id=0954ebc2f957cf2e90765479f64a4e8784f76a75

Its like that Debian bug from Frank does: documents what that
--transform is doing so that we don't scratch our heads that much :-)

- Arnaldo

  reply	other threads:[~2021-08-13  0:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 19:00 pahole: Problems with lib/include/bpf symlink in a tarball with --transform Arnaldo Carvalho de Melo
2021-08-12 19:06 ` Arnaldo Carvalho de Melo
2021-08-12 21:50   ` Luca Boccassi
2021-08-13  0:05     ` Arnaldo Carvalho de Melo [this message]
2021-08-13 18:15 ` Frank Heckenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRW3SRQtoOtEyUem@kernel.org \
    --to=acme@kernel.org \
    --cc=bluca@debian.org \
    --cc=dwarves@vger.kernel.org \
    --cc=f.heckenbach@fh-soft.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).