From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587)
Date: Tue, 1 May 2018 00:11:56 -0300 [thread overview]
Message-ID: <e051ffeb-fee1-2f20-d011-6b6f9b5181ab@amsat.org> (raw)
In-Reply-To: <20180430170156.1860-1-laurent@vivier.eu>
On 04/30/2018 02:01 PM, Laurent Vivier wrote:
> return the result of packFloatx80() instead of
> dropping it.
(missed in 4b5c65b8f02).
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/m68k/softfloat.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c
> index dffb371c71..2c069a5efb 100644
> --- a/target/m68k/softfloat.c
> +++ b/target/m68k/softfloat.c
> @@ -334,7 +334,8 @@ floatx80 floatx80_lognp1(floatx80 a, float_status *status)
> if (aSign && aExp >= one_exp) {
> if (aExp == one_exp && aSig == one_sig) {
> float_raise(float_flag_divbyzero, status);
> - packFloatx80(aSign, floatx80_infinity.high, floatx80_infinity.low);
> + return packFloatx80(aSign, floatx80_infinity.high,
> + floatx80_infinity.low);
> }
> float_raise(float_flag_invalid, status);
> return floatx80_default_nan(status);
>
prev parent reply other threads:[~2018-05-01 3:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 17:01 [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587) Laurent Vivier
2018-04-30 17:01 ` [Qemu-devel] [PATCH 2/2] m68k: remove dead code (Coverity CID1390617) Laurent Vivier
2018-04-30 17:25 ` Peter Maydell
2018-04-30 17:24 ` [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587) Peter Maydell
2018-05-01 3:11 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e051ffeb-fee1-2f20-d011-6b6f9b5181ab@amsat.org \
--to=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.