From: Nikolay Borisov <nborisov@suse.com>
To: qiang.zhang@windriver.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix missing close devices
Date: Wed, 23 Sep 2020 14:15:13 +0300 [thread overview]
Message-ID: <e0ba2e26-c336-a9e4-1377-78e8d9507052@suse.com> (raw)
In-Reply-To: <20200921072926.24639-1-qiang.zhang@windriver.com>
On 21.09.20 г. 10:29 ч., qiang.zhang@windriver.com wrote:
> From: Zqiang <qiang.zhang@windriver.com>
>
> When the btrfs fill super error, we should first close devices and
> then call deactivate_locked_super func to free fs_info.
>
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>
> ---
> fs/btrfs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 8840a4fa81eb..3bfd54e8f388 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -1675,6 +1675,7 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type,
> error = security_sb_set_mnt_opts(s, new_sec_opts, 0, NULL);
> security_free_mnt_opts(&new_sec_opts);
> if (error) {
> + btrfs_close_devices(fs_devices);
> deactivate_locked_super(s);
> return ERR_PTR(error);
> }
>
NAK,
Devices are properly closed via:
deactivate_locked_super
kill_sb (btrfs_kill_super)
kill_anon_super
generic_shutdown_super
put_super (btrfs_put_super)
close_ctree
It seems you haven't done deep enough analysis of the involved call chains.
next prev parent reply other threads:[~2020-09-23 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 7:29 [PATCH] btrfs: Fix missing close devices qiang.zhang
2020-09-21 12:55 ` Johannes Thumshirn
2020-09-23 11:15 ` Nikolay Borisov [this message]
2020-09-21 8:26 qiang.zhang
2020-09-21 8:52 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0ba2e26-c336-a9e4-1377-78e8d9507052@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.