From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: "Wei Liu" <wei.liu2@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 4/6] xen: don't free percpu areas during suspend
Date: Wed, 27 Mar 2019 15:55:10 +0000 [thread overview]
Message-ID: <e10c14cd-54ac-8d8c-2d5c-db4adbd39d07@citrix.com> (raw)
In-Reply-To: <20190318131155.29450-5-jgross@suse.com>
On 18/03/2019 13:11, Juergen Gross wrote:
> Instead of freeing percpu areas during suspend and allocating them
> again when resuming keep them. Only free an area in case a cpu didn't
> come up again when resuming.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Hmm - this is slightly problematic, given the dual nature of this code.
I agree that it this change is beneficial for the suspend case, but it
is a problem when we are parking an individual CPU for smt=0 or
xen-hptool reasons.
Do we have any hint we can use when taking the CPU down as to whether
we're expecting it to come straight back up again?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-27 16:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 13:11 [PATCH 0/6] xen: simplify suspend/resume handling Juergen Gross
2019-03-18 13:11 ` [PATCH 1/6] xen/sched: call cpu_disable_scheduler() via cpu notifier Juergen Gross
2019-03-27 15:34 ` Andrew Cooper
2019-03-27 15:35 ` George Dunlap
2019-03-27 16:22 ` Jan Beulich
2019-03-27 16:24 ` Dario Faggioli
2019-03-27 16:31 ` Juergen Gross
2019-03-27 16:51 ` Dario Faggioli
2019-03-27 16:53 ` Juergen Gross
[not found] ` <5C9BA336020000780022235B@suse.com>
2019-03-27 16:45 ` Juergen Gross
2019-03-27 16:58 ` Jan Beulich
2019-03-18 13:11 ` [PATCH 2/6] xen: add helper for calling notifier_call_chain() to common/cpu.c Juergen Gross
2019-03-25 11:56 ` Dario Faggioli
2019-03-27 12:25 ` George Dunlap
2019-03-27 15:39 ` Andrew Cooper
2019-03-27 16:05 ` Juergen Gross
2019-03-18 13:11 ` [PATCH 3/6] xen: add new cpu notifier action CPU_RESUME_FAILED Juergen Gross
2019-03-25 12:21 ` Dario Faggioli
2019-03-25 12:29 ` Juergen Gross
2019-03-27 15:54 ` Dario Faggioli
2019-03-27 15:49 ` George Dunlap
2019-03-27 16:29 ` Jan Beulich
[not found] ` <5C9BA5010200007800222375@suse.com>
2019-03-27 16:32 ` Juergen Gross
2019-03-18 13:11 ` [PATCH 4/6] xen: don't free percpu areas during suspend Juergen Gross
2019-03-25 18:14 ` Dario Faggioli
2019-03-27 15:55 ` Andrew Cooper [this message]
2019-03-27 16:18 ` Juergen Gross
2019-03-27 16:38 ` Jan Beulich
[not found] ` <5C9BA70E02000078002223A3@suse.com>
2019-03-27 16:52 ` Juergen Gross
2019-03-28 6:59 ` Juergen Gross
2019-03-28 8:03 ` Jan Beulich
2019-04-11 9:49 ` Jan Beulich
2019-04-11 9:49 ` [Xen-devel] " Jan Beulich
[not found] ` <5C9C7FD202000078002225AB@suse.com>
2019-03-28 8:35 ` Juergen Gross
2019-03-28 9:36 ` Jan Beulich
2019-03-28 7:46 ` Jan Beulich
[not found] ` <5C9C7BF1020000780022258F@suse.com>
2019-03-28 7:53 ` Juergen Gross
2019-03-28 8:04 ` Jan Beulich
2019-03-18 13:11 ` [PATCH 5/6] xen/cpupool: simplify suspend/resume handling Juergen Gross
2019-03-27 15:56 ` George Dunlap
2019-03-27 16:32 ` Dario Faggioli
2019-03-18 13:11 ` [PATCH 6/6] xen/sched: don't disable scheduler on cpus during suspend Juergen Gross
2019-03-27 23:10 ` Dario Faggioli
2019-03-28 5:41 ` Juergen Gross
-- strict thread matches above, loose matches on Subject: below --
2019-03-28 8:35 [PATCH 4/6] xen: don't free percpu areas " Juergen Gross
[not found] <20190318131155.29450*1*jgross@suse.com>
[not found] ` <20190318131155.29450*5*jgross@suse.com>
[not found] <20190318131155.29450****1****jgross@suse.com>
[not found] ` <20190318131155.29450****5****jgross@suse.com>
[not found] ` <e10c14cd****54ac****8d8c****2d5c****db4adbd39d07@citrix.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10c14cd-54ac-8d8c-2d5c-db4adbd39d07@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.