From: Shawn Lin <shawn.lin@rock-chips.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
shawn.lin@rock-chips.com,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-block <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Paolo Valente <paolo.valente@linaro.org>,
Avri Altman <Avri.Altman@sandisk.com>,
Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: [PATCH 1/2 v6] mmc: block: Convert RPMB to a character device
Date: Thu, 28 Sep 2017 11:56:11 +0800 [thread overview]
Message-ID: <e18231a7-c50b-c3d9-ca5b-be26f6ac81fc@rock-chips.com> (raw)
In-Reply-To: <CACRpkdabXNgCz+mtOOAZR1OqbCT0VgpxKT=FPh_99DTnsnCcSQ@mail.gmail.com>
On 2017/9/28 3:45, Linus Walleij wrote:
> On Wed, Sep 27, 2017 at 1:35 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> BUG when removing, fixed by reverting this patch.
>>
>> [ 346.548512] mmc1: card 0001 removed
>> [ 346.552782] BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
>
> How did you achieve this? I need to reproduce it.
>
> RPMB is only available on eMMC cards and I don't have a removable eMMC
> card since by definition they are soldered on.
>
> Does it happen on an ordinary MMC card without RPMB?
>
> I'm sorry if I'm ignorant of something very obvious here...
>
> I will read the code and see if I'm missing something obvious.
Haven't closely look at this patch, but btw, don't you need
put_device(&rpmb->dev) for the error path of mmc_blk_alloc_rpmb_part
and also do that for mmc_blk_remove_rpmb_part?
And don't you need to check rpmb->md->usage when doing
mmc_blk_remove_rpmb_part ?
>
> Yours,
> Linus Walleij
>
>
>
next prev parent reply other threads:[~2017-09-28 3:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:02 [PATCH 1/2 v6] mmc: block: Convert RPMB to a character device Linus Walleij
2017-09-20 8:02 ` [PATCH 2/2 v6] mmc: block: Delete mmc_access_rpmb() Linus Walleij
2017-09-22 9:46 ` Ulf Hansson
2017-09-22 9:46 ` [PATCH 1/2 v6] mmc: block: Convert RPMB to a character device Ulf Hansson
2017-09-27 11:35 ` Adrian Hunter
2017-09-27 19:45 ` Linus Walleij
2017-09-28 3:56 ` Shawn Lin [this message]
2017-09-28 6:00 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e18231a7-c50b-c3d9-ca5b-be26f6ac81fc@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=Avri.Altman@sandisk.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=hch@lst.de \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tomas.winkler@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.