From: "Sanchit Jindal via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Sanchit Jindal <sanchit1053@gmail.com>,
Sanchit Jindal <sanchit1053@gmail.com>
Subject: [PATCH v2 2/2] t9803: update commit messages and description
Date: Thu, 21 Mar 2024 20:29:06 +0000 [thread overview]
Message-ID: <e25b5f928a9427de57ff1963d9fb4bca2b86e829.1711052946.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1691.v2.git.git.1711052946.gitgitgadget@gmail.com>
From: Sanchit Jindal <sanchit1053@gmail.com>
Using the `test` function directly does not provide any
diagnostic information to the user, in case of a failure.
This patch replace the `test` function with the helper functions
defined that will call the corresponding test function and log an
error message if the assert fails
Making the replacements
- `test -e` -> test_path_exists,
- `test ! -e` -> test_path_is_missing
- `test -f` -> test_path_is_file
Signed-off-by: Sanchit Jindal <sanchit1053@gmail.com>
--
gitgitgadget
prev parent reply other threads:[~2024-03-21 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 19:39 [PATCH 0/2] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions Sanchit Jindal via GitGitGadget
2024-03-21 19:39 ` [PATCH 1/2] " sanchit1053 via GitGitGadget
2024-03-21 19:39 ` [PATCH 2/2] t9803: update commit messages and description Sanchit Jindal via GitGitGadget
2024-03-21 19:52 ` Eric Sunshine
2024-03-21 20:28 ` Sanchit Jindal
2024-03-21 23:25 ` Junio C Hamano
2024-03-21 20:29 ` [PATCH v2 0/2] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions Sanchit Jindal via GitGitGadget
2024-03-21 20:29 ` [PATCH v2 1/2] " sanchit1053 via GitGitGadget
2024-03-21 20:29 ` Sanchit Jindal via GitGitGadget [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25b5f928a9427de57ff1963d9fb4bca2b86e829.1711052946.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=sanchit1053@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.