From: Shuah Khan <skhan@linuxfoundation.org>
To: David Hildenbrand <david@redhat.com>,
zhaogongyi <zhaogongyi@huawei.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Cc: "akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"osalvador@suse.de" <osalvador@suse.de>,
"shuah@kernel.org" <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit
Date: Mon, 10 Oct 2022 11:02:29 -0600 [thread overview]
Message-ID: <e26efc62-327f-946e-6a0a-151151485589@linuxfoundation.org> (raw)
In-Reply-To: <b0ae9fcc-7e2b-dae9-30be-4b6ee248bf97@redhat.com>
On 10/10/22 00:54, David Hildenbrand wrote:
> On 08.10.22 03:40, zhaogongyi wrote:
>>
>> Yes, online_memory_expect_success() already prints a warning, remove the warning in online_all_offline_memory() seems ok,
>>
>> My previous consideration was that one more log information would make it easier to locate the wrong location.
>
> Let's keep it simple unless there is real reason to warn twice.
>
zhaogongyi,
Please note that I already applied the patches to linux-kselftest
next for my second pull request before the merge window. Please
send the change David requested in a separate patch on top of
next as a fix.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-10-10 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 1:40 [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit zhaogongyi
2022-10-10 6:54 ` David Hildenbrand
2022-10-10 17:02 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-11 1:48 zhaogongyi
2022-09-30 8:52 zhaogongyi
2022-09-30 8:56 ` David Hildenbrand
2022-09-30 6:35 [PATCH -next v5 0/4] Optimize and bugfix for memory-hotplug Zhao Gongyi
2022-09-30 6:35 ` [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit Zhao Gongyi
2022-09-30 8:33 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e26efc62-327f-946e-6a0a-151151485589@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.