From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+904752567107eefb728c@syzkaller.appspotmail.com
Subject: Re: [PATCH] KVM: x86: Initialize tdp_level during vCPU creation
Date: Wed, 27 May 2020 18:56:02 +0200 [thread overview]
Message-ID: <e2b9d767-df19-2974-8457-737b925749d3@redhat.com> (raw)
In-Reply-To: <20200527162318.GD24461@linux.intel.com>
On 27/05/20 18:23, Sean Christopherson wrote:
> Hmm, one option would be to make .get_tdp_level() pure function by passing
> in vcpu->arch.maxphyaddr. That should make the comment redundant. I don't
> love bleeding VMX's implementation into the prototype, but that ship has
> kinda already sailed.
Well, it's not bleeding the implementation that much, guest MAXPHYADDR
is pretty much the only reason why it's a function and not a constant.
Another possibility BTW is to make the callback get_max_tdp_level and
make get_tdp_level a function in mmu.c.
Paolo
next prev parent reply other threads:[~2020-05-27 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:54 [PATCH] KVM: x86: Initialize tdp_level during vCPU creation Sean Christopherson
2020-05-27 10:03 ` Vitaly Kuznetsov
2020-05-27 16:15 ` Paolo Bonzini
2020-05-27 16:23 ` Sean Christopherson
2020-05-27 16:56 ` Paolo Bonzini [this message]
2020-05-28 2:27 ` Sean Christopherson
2020-05-27 16:17 ` Paolo Bonzini
2020-05-27 16:29 ` Sean Christopherson
2020-05-27 16:56 ` Paolo Bonzini
2020-05-27 17:06 ` Sean Christopherson
2020-05-28 19:46 ` Sean Christopherson
2020-05-29 7:46 ` Vitaly Kuznetsov
2020-05-29 13:06 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b9d767-df19-2974-8457-737b925749d3@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=syzbot+904752567107eefb728c@syzkaller.appspotmail.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.