From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-integrity@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH 01/11] tpm: move buffer handling from static inlines to real functions
Date: Sun, 11 Dec 2022 22:16:42 -0500 [thread overview]
Message-ID: <e32ead8270f65fe7bf828fe90d457caac4234dce.camel@HansenPartnership.com> (raw)
In-Reply-To: <Y5Z7awuHL9Wsn2l/@kernel.org>
On Mon, 2022-12-12 at 00:52 +0000, Jarkko Sakkinen wrote:
> On Sun, Dec 11, 2022 at 03:01:57PM -0500, James Bottomley wrote:
> > On Sat, 2022-12-10 at 02:09 +0000, Jarkko Sakkinen wrote:
> > > On Fri, Dec 09, 2022 at 11:06:01AM -0500, James Bottomley wrote:
> > > > This separates out the old tpm_buf_... handling functions from
> > > > static
> > > > inlines in tpm.h and makes them their own tpm-buf.c file. This
> > > > is
> > > > a
> > > > precursor so we can add new functions for other TPM type
> > > > handling
> > > >
> > > > Signed-off-by: James Bottomley
> > > > <James.Bottomley@HansenPartnership.com>
> > >
> > > I don't comprehend that explanation at all.
> > >
> > > Please, add a bit more detail why this precursory change is
> > > required.
> >
> > It's the usual submitting-patches requirement of moving code first
> > before modifying it. Since it's the recommended way of doing
> > things in our process docs, I'm not sure how much more explanation
> > can be given.
>
> It doesn not contain any reasonable argument for not continue
> using inline functions.
In principle nothing prevents them being inlines in tpm.h. There's
quite a lot of them, so it's growing unweildy and __tpm_buf_init can't
be hidden in that scenario but it could, in theory, be done.
James
next prev parent reply other threads:[~2022-12-12 3:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 16:06 [PATCH 00/11] add integrity and security to TPM2 transactions James Bottomley
2022-12-09 16:06 ` [PATCH 01/11] tpm: move buffer handling from static inlines to real functions James Bottomley
2022-12-09 19:11 ` kernel test robot
2022-12-09 19:42 ` kernel test robot
2022-12-10 2:09 ` Jarkko Sakkinen
2022-12-11 20:01 ` James Bottomley
2022-12-12 0:52 ` Jarkko Sakkinen
2022-12-12 3:16 ` James Bottomley [this message]
2022-12-26 20:03 ` Jarkko Sakkinen
2022-12-09 16:06 ` [PATCH 02/11] tpm: add buffer handling for TPM2B types James Bottomley
2022-12-09 16:06 ` [PATCH 03/11] tpm: add cursor based buffer functions for response parsing James Bottomley
2022-12-12 0:50 ` Jarkko Sakkinen
2022-12-12 3:13 ` James Bottomley
2022-12-26 20:06 ` Jarkko Sakkinen
2022-12-09 16:06 ` [PATCH 04/11] tpm: add buffer function to point to returned parameters James Bottomley
2022-12-09 16:06 ` [PATCH 05/11] tpm: export the context save and load commands James Bottomley
2022-12-09 16:06 ` [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code James Bottomley
2022-12-09 16:15 ` James Bottomley
2022-12-09 19:42 ` kernel test robot
2022-12-09 20:32 ` kernel test robot
2022-12-09 16:06 ` [PATCH 07/11] tpm: add hmac checks to tpm2_pcr_extend() James Bottomley
2022-12-09 16:06 ` [PATCH 08/11] tpm: add session encryption protection to tpm2_get_random() James Bottomley
2022-12-09 16:06 ` [PATCH 09/11] KEYS: trusted: Add session encryption protection to the seal/unseal path James Bottomley
2022-12-09 16:06 ` [PATCH 10/11] tpm: add the null key name as a sysfs export James Bottomley
2022-12-09 16:06 ` [PATCH 11/11] Documentation: add tpm-security.rst James Bottomley
2022-12-10 4:27 [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code kernel test robot
2022-12-10 5:17 ` Dan Carpenter
2022-12-11 20:05 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e32ead8270f65fe7bf828fe90d457caac4234dce.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.