From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xen.org
Subject: Re: staging aarch64 build fails in xc_dom_arm.c
Date: Tue, 30 May 2017 16:43:25 +0100 [thread overview]
Message-ID: <e4203549-d231-d195-c311-53019c85dcb3@citrix.com> (raw)
In-Reply-To: <20170530154000.GG26792@aepfle.de>
On 30/05/17 16:40, Olaf Hering wrote:
> On Tue, May 30, Andrew Cooper wrote:
>
>> Does
>> + domctl.u.address_size.size = 0;
>> help?
> Likely yes. I just scanned the buildlogs and found this failure.
> I do not have a ARM toolchain around to double check.
> Not sure why the marco, or its usage, is not like 'struct xen_domctl domctl = {}'
I've never been convinced by the utility of those macros. All they do
is make it cognitively harder to read the code.
I think I even tried to kill them once, but got nacked.
Either way, my position still stands that they should be relegated to
/dev/null and we pretend that they never existed.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-05-30 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 15:27 staging aarch64 build fails in xc_dom_arm.c Olaf Hering
2017-05-30 15:34 ` Andrew Cooper
2017-05-30 15:40 ` Olaf Hering
2017-05-30 15:43 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4203549-d231-d195-c311-53019c85dcb3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.