From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>, <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] libacpi: Widen TPM detection
Date: Thu, 11 Jun 2020 12:52:01 +0100 [thread overview]
Message-ID: <e43dbb75-5e37-ee2f-b856-7e86baa1810c@citrix.com> (raw)
In-Reply-To: <20200611035518.379297-1-jandryuk@gmail.com>
On 11/06/2020 04:55, Jason Andryuk wrote:
> The hardcoded tpm_signature is too restrictive to detect many TPMs. For
> instance, it doesn't accept a QEMU emulated TPM (VID 0x1014 DID 0x0001).
> Make the TPM detection match that in rombios which accepts a wider
> range.
>
> With this change, the TPM's TCPA ACPI table is generated and the guest
> OS can automatically load the tpm_tis driver. It also allows seabios to
> detect and use the TPM. However, seabios skips some TPM initialization
> when running under Xen, so it will not populate any PCRs unless modified
> to run the initialization under Xen.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This looks like it wants backporting, so CC'ing Paul for a 4.14 release ack.
next prev parent reply other threads:[~2020-06-11 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 3:55 [PATCH] libacpi: Widen TPM detection Jason Andryuk
2020-06-11 11:52 ` Andrew Cooper [this message]
2020-06-11 12:07 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43dbb75-5e37-ee2f-b856-7e86baa1810c@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jandryuk@gmail.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.