From: Lars-Peter Clausen <lars@metafoo.de>
To: Aastha Gupta <aastha.gupta4104@gmail.com>,
outreachy-kernel@googlegroups.com,
hennerich@blackfin.uclinux.org, jic23@kernel.org,
knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 0/2] staging: iio: adc: ad7192: use private driver lock to protect hardware changes
Date: Tue, 26 Sep 2017 20:15:31 +0200 [thread overview]
Message-ID: <e4b443c0-7d7f-e353-61c5-32867bfe01eb@metafoo.de> (raw)
In-Reply-To: <1506440468-5081-1-git-send-email-aastha.gupta4104@gmail.com>
On 09/26/2017 05:41 PM, Aastha Gupta wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> These patches
> - replace mlock with private driver lock
> - add lock where there are hardware state changes
For this to make sense both changes need to be in the same patch. You are
removing the protection in patch 1 and then adding it back in patch 2. A
patch series shouldn't leave the driver in a broken intermediate state if
only part of the series is applied.
prev parent reply other threads:[~2017-09-26 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 15:41 [PATCH v2 0/2] staging: iio: adc: ad7192: use private driver lock to protect hardware changes Aastha Gupta
2017-09-26 15:41 ` [PATCH v2 1/2] staging: iio: adc: ad7192: Replace mlock with driver private lock Aastha Gupta
2017-09-26 15:41 ` [PATCH v2 2/2] staging: iio: adc: ad7192: add lock to protect hardware state changes Aastha Gupta
2017-09-26 18:15 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b443c0-7d7f-e353-61c5-32867bfe01eb@metafoo.de \
--to=lars@metafoo.de \
--cc=aastha.gupta4104@gmail.com \
--cc=hennerich@blackfin.uclinux.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.