Re: [RFC v2 11/11] vfio: Move vfio group specific code into group.c

From: Yi Liu <yi.l.liu@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: <alex.williamson@redhat.com>, <kevin.tian@intel.com>,
	<eric.auger@redhat.com>, <cohuck@redhat.com>,
	<nicolinc@nvidia.com>, <yi.y.sun@linux.intel.com>,
	<chao.p.peng@linux.intel.com>, <mjrosato@linux.ibm.com>,
	<kvm@vger.kernel.org>
Subject: Re: [RFC v2 11/11] vfio: Move vfio group specific code into group.c
Date: Fri, 25 Nov 2022 16:45:07 +0800	[thread overview]
Message-ID: <e4f8c00f-809c-01d8-c104-06bf84041116@intel.com> (raw)
In-Reply-To: <Y3+BXHd7dEL7FYqz@nvidia.com>

On 2022/11/24 22:36, Jason Gunthorpe wrote:
> On Thu, Nov 24, 2022 at 04:27:02AM -0800, Yi Liu wrote:
>> This prepares for compiling out vfio group after vfio device cdev is
>> added. No vfio_group decode code should be in vfio_main.c.
>>
>> No functional change is intended.
>>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>   drivers/vfio/Makefile    |   1 +
>>   drivers/vfio/group.c     | 842 +++++++++++++++++++++++++++++++++++++++
>>   drivers/vfio/vfio.h      |  17 +
>>   drivers/vfio/vfio_main.c | 830 +-------------------------------------
>>   4 files changed, 863 insertions(+), 827 deletions(-)
>>   create mode 100644 drivers/vfio/group.c
> 
> vfio_device_open_file() should be moved into group.c as well and
> export vfio_device_open/close() instead

also need export vfio_device_ops as well:-)

-- 
Regards,
Yi Liu