From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] oom, memcg: do not report racy no-eligible OOM
Date: Wed, 9 Jan 2019 20:34:46 +0900 [thread overview]
Message-ID: <e55fb27c-f23b-0ac5-acfd-7265c0a3b8dc@i-love.sakura.ne.jp> (raw)
In-Reply-To: <20190109110328.GS31793@dhcp22.suse.cz>
On 2019/01/09 20:03, Michal Hocko wrote:
> Tetsuo,
> can you confirm that these two patches are fixing the issue you have
> reported please?
>
My patch fixes the issue better than your "[PATCH 2/2] memcg: do not report racy no-eligible OOM tasks" does.
You can post "[PATCH 1/2] mm, oom: marks all killed tasks as oom victims"
based on a report that we needlessly select more OOM victims because
MMF_OOM_SKIP is quickly set by the OOM reaper. In fact, updating
oom_reap_task() / exit_mmap() to use
mutex_lock(&oom_lock);
set_bit(MMF_OOM_SKIP, &mm->flags);
mutex_unlock(&oom_lock);
will mostly close the race as well.
next prev parent reply other threads:[~2019-01-09 11:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 14:38 [PATCH 0/2] oom, memcg: do not report racy no-eligible OOM Michal Hocko
2019-01-07 14:38 ` Michal Hocko
2019-01-07 14:38 ` [PATCH 1/2] mm, oom: marks all killed tasks as oom victims Michal Hocko
2019-01-07 14:38 ` Michal Hocko
2019-01-07 20:58 ` Tetsuo Handa
2019-01-08 8:11 ` Michal Hocko
2019-01-07 14:38 ` [PATCH 2/2] memcg: do not report racy no-eligible OOM tasks Michal Hocko
2019-01-07 14:38 ` Michal Hocko
2019-01-07 20:59 ` Tetsuo Handa
2019-01-08 8:14 ` Michal Hocko
2019-01-08 10:39 ` Tetsuo Handa
2019-01-08 11:46 ` Michal Hocko
2019-01-08 8:35 ` kbuild test robot
2019-01-08 9:39 ` Michal Hocko
2019-01-11 0:23 ` [kbuild-all] " Rong Chen
2019-01-08 14:21 ` [PATCH 3/2] memcg: Facilitate termination of memcg OOM victims Tetsuo Handa
2019-01-08 14:38 ` Michal Hocko
2019-01-09 11:03 ` [PATCH 0/2] oom, memcg: do not report racy no-eligible OOM Michal Hocko
2019-01-09 11:34 ` Tetsuo Handa [this message]
2019-01-09 12:02 ` Michal Hocko
2019-01-10 23:59 ` Tetsuo Handa
2019-01-11 10:25 ` Tetsuo Handa
2019-01-11 11:33 ` Michal Hocko
2019-01-11 12:40 ` Tetsuo Handa
2019-01-11 13:34 ` Michal Hocko
2019-01-11 14:31 ` Tetsuo Handa
2019-01-11 15:07 ` Michal Hocko
2019-01-11 15:37 ` Tetsuo Handa
2019-01-11 16:45 ` Michal Hocko
2019-01-12 10:52 ` Tetsuo Handa
2019-01-13 17:36 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e55fb27c-f23b-0ac5-acfd-7265c0a3b8dc@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.