From: Michael Goldish <mgoldish@redhat.com>
To: kvm@vger.kernel.org
Cc: Michael Goldish <mgoldish@redhat.com>
Subject: [KVM-AUTOTEST PATCH] kvm_vm.py: add new VM parameter 'x11_display' that controls $DISPLAY
Date: Sun, 24 May 2009 18:46:46 +0300 [thread overview]
Message-ID: <e581284215a95ca22c45b17a39d891809399cbf5.1243179847.git.mgoldish@redhat.com> (raw)
In-Reply-To: <43f85767b32b927ca5e32abc5ded281915343656.1243179847.git.mgoldish@redhat.com>
In-Reply-To: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com>
If x11_display is specified, the DISPLAY environment variable is set to this
value for the QEMU process. This may be useful for SDL rendering.
Also add some comments.
Signed-off-by: Michael Goldish <mgoldish@redhat.com>
---
client/tests/kvm_runtest_2/kvm_vm.py | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm_runtest_2/kvm_vm.py b/client/tests/kvm_runtest_2/kvm_vm.py
index 9571a3b..7a4ce4a 100644
--- a/client/tests/kvm_runtest_2/kvm_vm.py
+++ b/client/tests/kvm_runtest_2/kvm_vm.py
@@ -173,6 +173,8 @@ class VM:
(iso_dir is pre-pended to the ISO filename)
extra_params -- a string to append to the qemu command
ssh_port -- should be 22 for SSH, 23 for Telnet
+ x11_display -- if specified, the DISPLAY environment variable will be be set
+ to this value for the qemu process (useful for SDL rendering)
images -- a list of image object names, separated by spaces
nics -- a list of NIC object names, separated by spaces
@@ -198,8 +200,16 @@ class VM:
if iso_dir == None:
iso_dir = self.iso_dir
- qemu_cmd = qemu_path
+ # Start constructing the qemu command
+ qemu_cmd = ""
+ # Set the X11 display parameter if requested
+ if params.get("x11_display"):
+ qemu_cmd += "DISPLAY=%s " % params.get("x11_display")
+ # Add the qemu binary
+ qemu_cmd += qemu_path
+ # Add the VM's name
qemu_cmd += " -name '%s'" % name
+ # Add the monitor socket parameter
qemu_cmd += " -monitor unix:%s,server,nowait" % self.monitor_file_name
for image_name in kvm_utils.get_sub_dict_names(params, "images"):
--
1.5.4.1
next prev parent reply other threads:[~2009-05-24 15:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 15:46 [KVM-AUTOTEST PATCH] RHEL-4.7 step files: fix the initial boot barriers Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] RHEL-5.3 step files: fix initial boot barriers and an inconsistent dialog Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] WinXP step files: add an optional barrier to deal with a closed start menu Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] stepeditor.py: get rid of some annoying keyboard shortcuts Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] Use new function VM.get_name() to get the VM's name, instead of VM.name Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] VM.create(): always destroy() the VM before attempting to start it Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] kvm_vm.py: choose a monitor filename in the constructor instead of VM.create() Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] kvm_vm.py: make sure the bulk of VM.create() is not executed in parallel Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] kvm_vm.py: add new function VM.clone() which returns a clone of the VM Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching Michael Goldish
2009-05-24 15:46 ` Michael Goldish [this message]
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter Michael Goldish
2009-05-24 15:46 ` [KVM-AUTOTEST PATCH] kvm_runtest_2.py: use pickle instead of shelve when loading/saving env Michael Goldish
2009-05-28 13:26 ` Lucas Meneghel Rodrigues
2009-05-24 19:03 ` [KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter sudhir kumar
2009-05-28 13:26 ` Lucas Meneghel Rodrigues
2009-05-28 13:26 ` [KVM-AUTOTEST PATCH] kvm_vm.py: add new VM parameter 'x11_display' that controls $DISPLAY Lucas Meneghel Rodrigues
2009-05-24 18:59 ` [KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching sudhir kumar
2009-05-29 6:12 ` Lucas Meneghel Rodrigues
2009-05-25 12:01 ` [KVM-AUTOTEST PATCH] kvm_vm.py: add new function VM.clone() which returns a clone of the VM Avi Kivity
2009-05-24 19:25 ` [KVM-AUTOTEST PATCH] kvm_vm.py: make sure the bulk of VM.create() is not executed in parallel sudhir kumar
2009-05-28 14:17 ` [KVM-AUTOTEST PATCH] VM.create(): always destroy() the VM before attempting to start it Lucas Meneghel Rodrigues
2009-05-28 13:06 ` [KVM-AUTOTEST PATCH] Use new function VM.get_name() to get the VM's name, instead of VM.name Lucas Meneghel Rodrigues
2009-06-03 5:01 ` Michael Goldish
2009-06-03 23:26 ` Lucas Meneghel Rodrigues
2009-05-24 19:31 ` [KVM-AUTOTEST PATCH] WinXP step files: add an optional barrier to deal with a closed start menu sudhir kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e581284215a95ca22c45b17a39d891809399cbf5.1243179847.git.mgoldish@redhat.com \
--to=mgoldish@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.