From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
Rob Herring <robh+dt@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH 03/18] MIPS: DTS: jz4780: fix tcu timer as reported by dtbscheck
Date: Sat, 9 Apr 2022 13:11:48 +0200 [thread overview]
Message-ID: <e5ea96d8-f8c9-b925-04ee-81e80e30a5d0@linaro.org> (raw)
In-Reply-To: <c48277625f0ab5afc86d89deb1b87537e9c592f6.1649443080.git.hns@goldelico.com>
On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
> arch/mips/boot/dts/ingenic/ci20.dtb: timer@10002000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['ingenic,jz4780-tcu', 'ingenic,jz4770-tcu', 'simple-mfd'] is too long
> 'ingenic,jz4780-tcu' is not one of ['ingenic,jz4740-tcu', 'ingenic,jz4725b-tcu', 'ingenic,jz4760-tcu', 'ingenic,x1000-tcu']
> 'simple-mfd' was expected
> 'ingenic,jz4760-tcu' was expected
Trim it a bit...
> From schema: Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
You need to explain this. You're changing the effective compatible of
the device and doing so based only on schema warning does not look
enough. Please write real reason instead of this fat warning, e.g. that
both devices are actually compatible and this has no real effect except
schema checks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-09 11:11 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 18:37 [PATCH 00/18] MIPS: DTS: fix some findings by "make ci20_defconfig dt_binding_check dtbs_check" H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 01/18] MIPS: DTS: jz4780: remove cpu clock-names as reported by dtbscheck H. Nikolaus Schaller
2022-04-09 11:07 ` Krzysztof Kozlowski
2022-04-09 13:02 ` H. Nikolaus Schaller
2022-04-09 13:10 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 02/18] MIPS: DTS: jz4780: fix cgu " H. Nikolaus Schaller
2022-04-09 11:07 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 03/18] MIPS: DTS: jz4780: fix tcu timer " H. Nikolaus Schaller
2022-04-09 11:11 ` Krzysztof Kozlowski [this message]
2022-04-09 12:24 ` Paul Cercueil
2022-04-09 12:38 ` Krzysztof Kozlowski
2022-04-09 13:12 ` H. Nikolaus Schaller
2022-04-09 13:03 ` H. Nikolaus Schaller
2022-04-09 13:11 ` Krzysztof Kozlowski
2022-04-09 13:18 ` H. Nikolaus Schaller
2022-04-09 13:22 ` Krzysztof Kozlowski
2022-04-09 13:30 ` H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 04/18] MIPS: DTS: jz4780: fix ost " H. Nikolaus Schaller
2022-04-09 11:12 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl " H. Nikolaus Schaller
2022-04-09 11:13 ` Krzysztof Kozlowski
2022-04-09 13:04 ` H. Nikolaus Schaller
2022-04-09 13:13 ` Krzysztof Kozlowski
2022-04-09 13:22 ` H. Nikolaus Schaller
2022-04-09 13:24 ` Krzysztof Kozlowski
2022-04-09 13:41 ` H. Nikolaus Schaller
2022-04-09 13:46 ` Krzysztof Kozlowski
2022-04-09 13:57 ` H. Nikolaus Schaller
2022-04-09 14:00 ` Krzysztof Kozlowski
2022-04-09 14:06 ` H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 06/18] MIPS: DTS: jz4780: fix rtc node " H. Nikolaus Schaller
2022-04-09 11:14 ` Krzysztof Kozlowski
2022-04-09 13:04 ` H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 07/18] MIPS: DTS: jz4780: fix otg " H. Nikolaus Schaller
2022-04-09 11:15 ` Krzysztof Kozlowski
2022-04-09 12:27 ` Paul Cercueil
2022-04-09 13:18 ` H. Nikolaus Schaller
2022-04-09 13:23 ` Krzysztof Kozlowski
2022-04-09 13:37 ` H. Nikolaus Schaller
2022-04-09 13:43 ` Paul Cercueil
2022-04-09 13:05 ` H. Nikolaus Schaller
2022-04-09 13:15 ` Krzysztof Kozlowski
2022-04-09 13:32 ` H. Nikolaus Schaller
2022-04-09 13:44 ` Krzysztof Kozlowski
2022-04-09 13:53 ` H. Nikolaus Schaller
2022-04-10 16:32 ` Zhou Yanjie
2022-04-10 19:13 ` H. Nikolaus Schaller
2022-04-12 9:49 ` Zhou Yanjie
2022-04-12 11:15 ` H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 08/18] MIPS: DTS: jz4780: fix lcd controllers " H. Nikolaus Schaller
2022-04-09 11:17 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 09/18] MIPS: DTS: jz4780: fix dma-controller " H. Nikolaus Schaller
2022-04-09 11:17 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 10/18] MIPS: DTS: jz4780: fix uart dmas " H. Nikolaus Schaller
2022-04-09 11:18 ` Krzysztof Kozlowski
2022-04-09 13:07 ` H. Nikolaus Schaller
2022-04-09 13:16 ` Krzysztof Kozlowski
2022-04-09 13:26 ` H. Nikolaus Schaller
2022-04-09 13:28 ` Krzysztof Kozlowski
2022-04-09 13:46 ` H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 11/18] MIPS: DTS: jz4780: fix i2c " H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 12/18] MIPS: DTS: jz4780: fix nemc memory controller " H. Nikolaus Schaller
2022-04-09 11:18 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 13/18] dt-bindings: fix jz4780-nemc issue " H. Nikolaus Schaller
2022-04-09 11:26 ` Krzysztof Kozlowski
2022-04-09 12:37 ` Paul Cercueil
2022-04-09 12:47 ` Krzysztof Kozlowski
2022-04-09 12:55 ` Paul Cercueil
2022-04-09 13:01 ` Krzysztof Kozlowski
2022-04-09 13:09 ` H. Nikolaus Schaller
2022-04-09 13:18 ` Krzysztof Kozlowski
2022-04-10 15:35 ` Krzysztof Kozlowski
2022-04-10 19:13 ` H. Nikolaus Schaller
2022-04-10 15:27 ` Rob Herring
2022-04-08 18:37 ` [PATCH 14/18] MIPS: DTS: CI20: add missing model " H. Nikolaus Schaller
2022-04-08 18:37 ` [PATCH 15/18] MIPS: DTS: CI20: fix fixed regulators " H. Nikolaus Schaller
2022-04-09 11:20 ` Krzysztof Kozlowski
2022-04-08 18:37 ` [PATCH 16/18] MIPS: DTS: CI20: fix /memory " H. Nikolaus Schaller
2022-04-08 18:38 ` [PATCH 17/18] MIPS: DTS: CI20: fix wifi " H. Nikolaus Schaller
2022-04-09 11:21 ` Krzysztof Kozlowski
2022-04-08 18:38 ` [PATCH 18/18] MIPS: DTS: CI20: fix bluetooth " H. Nikolaus Schaller
2022-04-09 11:22 ` Krzysztof Kozlowski
2022-04-09 13:10 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ea96d8-f8c9-b925-04ee-81e80e30a5d0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.