From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Damien Le Moal" <dlemoal@kernel.org>
Cc: <linux-ide@vger.kernel.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH 4/4] ata: pata_gayle: Convert to platform remove callback returning void
Date: Mon, 6 Nov 2023 12:57:40 +0300 [thread overview]
Message-ID: <e656470c-0d91-5fcc-5096-cf47b29489de@omp.ru> (raw)
In-Reply-To: <20231105150037.3724669-10-u.kleine-koenig@pengutronix.de>
On 11/5/23 6:00 PM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2023-11-06 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 15:00 [PATCH 0/4] ata: Drop platform_driver_probe() and convert to platform remove callback returning void (part II) Uwe Kleine-König
2023-11-05 15:00 ` [PATCH 1/4] ata: pata_falcon: Stop using module_platform_driver_probe() Uwe Kleine-König
2023-11-06 9:55 ` Sergey Shtylyov
2023-11-05 15:00 ` [PATCH 2/4] ata: pata_gayle: " Uwe Kleine-König
2023-11-06 9:55 ` Sergey Shtylyov
2023-11-05 15:00 ` [PATCH 3/4] ata: pata_falcon: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-06 9:56 ` Sergey Shtylyov
2023-11-05 15:00 ` [PATCH 4/4] ata: pata_gayle: " Uwe Kleine-König
2023-11-06 9:57 ` Sergey Shtylyov [this message]
2023-11-07 10:32 ` [PATCH 0/4] ata: Drop platform_driver_probe() and convert to platform remove callback returning void (part II) Niklas Cassel
2023-11-08 1:10 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e656470c-0d91-5fcc-5096-cf47b29489de@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=dlemoal@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-ide@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.