From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
david@redhat.com
Subject: Re: [PATCH 2/2] selftests: kvm: Add mem_slot_test test
Date: Thu, 2 Apr 2020 10:56:18 -0300 [thread overview]
Message-ID: <e6676068-3214-f9bf-832b-889facc8b091@redhat.com> (raw)
In-Reply-To: <20200402090029.pc6w6iqikgthflhq@kamzik.brq.redhat.com>
On 4/2/20 6:00 AM, Andrew Jones wrote:
> On Mon, Mar 30, 2020 at 05:43:10PM -0300, Wainer dos Santos Moschetta wrote:
>> This patch introduces the mem_slot_test test which checks
>> an VM can have added memory slots up to the limit defined in
>> KVM_CAP_NR_MEMSLOTS. Then attempt to add one more slot to
>> verify it fails as expected.
>>
>> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>> ---
>> tools/testing/selftests/kvm/.gitignore | 1 +
>> tools/testing/selftests/kvm/Makefile | 3 +
>> tools/testing/selftests/kvm/mem_slot_test.c | 92 +++++++++++++++++++++
>> 3 files changed, 96 insertions(+)
>> create mode 100644 tools/testing/selftests/kvm/mem_slot_test.c
>>
> BTW, in kvm/queue we also now have
>
> x86_64/set_memory_region_test.c
>
> I wonder if we shouldn't try to make x86_64/set_memory_region_test.c
> arch-neutral and then integrate this new test with it.
When I started work on this test I called it "add_max_mem_slots" but
then I realized it could be rather a suite for other tests, so it was
renamed. So yes, I think we can try to merge those memory region tests
altogether.
I'm about to send a v2 where I address all your comments and hopefully
we can use as the base for such as integration. Makes sense?
Thanks!
- Wainer
>
> Thanks,
> drew
next prev parent reply other threads:[~2020-04-02 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 20:43 [PATCH 0/2] selftests: kvm: Introduce the mem_slot_test test Wainer dos Santos Moschetta
2020-03-30 20:43 ` [PATCH 1/2] selftests: kvm: Add vm_get_fd() in kvm_util Wainer dos Santos Moschetta
2020-03-31 7:52 ` Andrew Jones
2020-03-30 20:43 ` [PATCH 2/2] selftests: kvm: Add mem_slot_test test Wainer dos Santos Moschetta
2020-03-31 8:16 ` Andrew Jones
2020-03-31 21:42 ` Wainer dos Santos Moschetta
2020-04-01 6:38 ` Andrew Jones
2020-04-02 13:48 ` Wainer dos Santos Moschetta
2020-04-02 9:00 ` Andrew Jones
2020-04-02 13:56 ` Wainer dos Santos Moschetta [this message]
2020-04-02 14:44 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6676068-3214-f9bf-832b-889facc8b091@redhat.com \
--to=wainersm@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.