From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")
Date: Fri, 29 May 2020 20:50:46 +0200 [thread overview]
Message-ID: <e66a6749-29a1-af23-6d07-6b3c4fd45220@gmail.com> (raw)
In-Reply-To: <2e1ee784-7493-284b-96f9-96b2e0c4b817@gmail.com>
On 28.05.2020 23:44, Heiner Kallweit wrote:
> For whatever reason with this change (and losing ASPM control) I also
> loose the PCIe PME interrupts. This prevents my network card from
> resuming from runtime-suspend.
> Reverting the change brings back ASPM control and the PCIe PME irq's.
>
> Affected system is a Zotac MiniPC with a N3450 CPU:
> PCI bridge: Intel Corporation Celeron N3350/Pentium N4200/Atom E3900 Series PCI Express Port A #1 (rev fb)
>
I checked a little bit further and w/o ASPM control the root ports
don't have the PME service bit set in their capabilities.
Not sure whether this is a chipset bug or whether there's a better
explanation. However more chipsets may have such a behavior.
W/o the "default y" for ASPM control we also have the situation now
that the config option description says "When in doubt, say Y."
but it takes the EXPERT mode to enable it. This seems to be a little
bit inconsistent.
To cut a long story short:
At least on some systems this change has unwanted side effects.
next prev parent reply other threads:[~2020-05-29 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 21:44 Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default") Heiner Kallweit
2020-05-29 18:50 ` Heiner Kallweit [this message]
2020-05-29 19:21 ` Bjorn Helgaas
2020-05-29 19:40 ` Heiner Kallweit
2020-05-29 20:09 ` Heiner Kallweit
2020-05-29 20:21 ` Bjorn Helgaas
2020-05-29 20:53 ` Heiner Kallweit
2020-05-29 20:59 ` Matthew Garrett
2020-05-29 22:26 ` Heiner Kallweit
2020-05-29 22:58 ` Matthew Garrett
2020-05-30 6:33 ` Heiner Kallweit
2020-05-30 7:14 ` Matthew Garrett
2020-05-30 11:33 ` Christoph Hellwig
2020-06-01 10:58 ` Rafael J. Wysocki
2020-06-01 15:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66a6749-29a1-af23-6d07-6b3c4fd45220@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.