From: Rafi Rubin <rafi@seas.upenn.edu>
To: Jiri Kosina <jikos@kernel.org>, Mingxuan Xiang <mx_xiang@hust.edu.cn>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dongliang Mu <dzm91@hust.edu.cn>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hid-ntrig: fix the error handling code in ntrig_probe
Date: Sun, 3 Apr 2022 14:34:48 -0400 [thread overview]
Message-ID: <e6b53360-6fa7-a295-cba1-9a27e2b3665f@seas.upenn.edu> (raw)
In-Reply-To: <nycvar.YFH.7.76.2203301722301.24795@cbobk.fhfr.pm>
The writable parameters are also settable as module parameters and I suspect are not really widely used. I used them for tuning the defaults and dealing with unreliable devices, not in the course of normal use. So I agree creation of the sysfs nodes
should not block probing and using the device.
Thank you for working on the error handling,
Rafi
prev parent reply other threads:[~2022-04-03 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 15:02 [PATCH] HID: hid-ntrig: fix the error handling code in ntrig_probe Mingxuan Xiang
2022-03-30 15:25 ` Jiri Kosina
2022-04-03 18:34 ` Rafi Rubin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b53360-6fa7-a295-cba1-9a27e2b3665f@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=benjamin.tissoires@redhat.com \
--cc=dzm91@hust.edu.cn \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mx_xiang@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.