From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Lorenzo Stoakes <lstoakes@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] mm/gup: remove vmas parameter from get_user_pages_remote()
Date: Sat, 15 Apr 2023 09:25:51 +0900 [thread overview]
Message-ID: <e715ec72-682f-291c-7131-8355843660d0@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <5a4cf1ebf1c6cdfabbf2f5209facb0180dd20006.1681508038.git.lstoakes@gmail.com>
On 2023/04/15 8:27, Lorenzo Stoakes wrote:
> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c
> index f5bcb0dc6267..74d8d4007dec 100644
> --- a/arch/arm64/kernel/mte.c
> +++ b/arch/arm64/kernel/mte.c
> @@ -437,8 +437,9 @@ static int __access_remote_tags(struct mm_struct *mm, unsigned long addr,
> struct page *page = NULL;
>
> ret = get_user_pages_remote(mm, addr, 1, gup_flags, &page,
> - &vma, NULL);
> - if (ret <= 0)
> + NULL);
> + vma = vma_lookup(mm, addr);
> + if (ret <= 0 || !vma)
> break;
This conversion looks wrong. When get_user_pages_remote(&page) returned > 0,
put_page(page) is needed even if vma_lookup() returned NULL, isn't it?
next prev parent reply other threads:[~2023-04-15 0:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 23:25 [PATCH 0/7] remove the vmas parameter from GUP APIs Lorenzo Stoakes
2023-04-14 23:27 ` [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages() Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-15 5:27 ` Greg Kroah-Hartman
2023-04-15 5:27 ` Greg Kroah-Hartman
2023-04-15 5:27 ` Greg Kroah-Hartman
2023-04-17 13:01 ` Jason Gunthorpe
2023-04-17 13:01 ` Jason Gunthorpe
2023-04-17 13:01 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 2/7] mm/gup: remove unused vmas parameter from pin_user_pages_remote() Lorenzo Stoakes
2023-04-17 13:02 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-15 0:25 ` Tetsuo Handa [this message]
2023-04-15 8:11 ` Lorenzo Stoakes
2023-04-17 13:09 ` Jason Gunthorpe
2023-04-17 13:09 ` Jason Gunthorpe
2023-04-17 13:13 ` Lorenzo Stoakes
2023-04-17 13:13 ` Lorenzo Stoakes
2023-04-17 13:16 ` Jason Gunthorpe
2023-04-17 13:16 ` Jason Gunthorpe
2023-04-17 13:23 ` Lorenzo Stoakes
2023-04-17 13:23 ` Lorenzo Stoakes
2023-04-17 15:07 ` Eric W. Biederman
2023-04-17 15:07 ` Eric W. Biederman
2023-04-17 15:14 ` Lorenzo Stoakes
2023-04-17 15:14 ` Lorenzo Stoakes
2023-04-14 23:27 ` [PATCH 4/7] mm/gup: introduce the FOLL_SAME_FILE GUP flag Lorenzo Stoakes
2023-04-17 13:14 ` Jason Gunthorpe
2023-04-17 13:25 ` Lorenzo Stoakes
2023-04-17 13:27 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 5/7] io_uring: rsrc: use FOLL_SAME_FILE on pin_user_pages() Lorenzo Stoakes
2023-04-17 12:56 ` Jason Gunthorpe
2023-04-17 13:19 ` Lorenzo Stoakes
2023-04-17 13:26 ` Jason Gunthorpe
2023-04-17 14:00 ` Lorenzo Stoakes
2023-04-17 14:15 ` Jason Gunthorpe
2023-04-17 15:20 ` Lorenzo Stoakes
2023-04-17 19:00 ` Lorenzo Stoakes
2023-04-17 19:24 ` Jason Gunthorpe
2023-04-17 19:45 ` Lorenzo Stoakes
2023-04-18 16:25 ` Pavel Begunkov
2023-04-18 16:35 ` Pavel Begunkov
2023-04-18 16:36 ` Jason Gunthorpe
2023-04-18 17:25 ` Pavel Begunkov
2023-04-18 18:19 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 6/7] mm/gup: remove vmas parameter from pin_user_pages() Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-14 23:27 ` [PATCH 7/7] mm/gup: remove vmas array from internal GUP functions Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e715ec72-682f-291c-7131-8355843660d0@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.