Re: [PATCH v2 3/4] arm64: dts: qcom: sdm630: add device node for the modem PAS

From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Marijn Suijten <marijn.suijten@somainline.org>
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sdm630: add device node for the modem PAS
Date: Wed, 29 Jun 2022 20:56:05 +0200	[thread overview]
Message-ID: <e7a465f3-5e9b-39c3-5a07-fa615ac69b61@somainline.org> (raw)
In-Reply-To: <20220521203520.1513565-4-dmitry.baryshkov@linaro.org>

On 21.05.2022 22:35, Dmitry Baryshkov wrote:
> Add device tree node describing modem device found on the SDM630/SDM660
> devices.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm630.dtsi | 59 ++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 55de345895e6..25b0067a93af 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1006,6 +1006,65 @@ data {
>  			};
>  		};
>  
> +		mss_pil: remoteproc@4080000 {
> +			compatible = "qcom,sdm660-mss-pil";
> +			reg = <0x04080000 0x408>, <0x04180000 0x48>;
> +			reg-names = "qdsp6", "rmb";
> +
> +			interrupts-extended =
> +				<&intc GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "wdog", "fatal", "ready",
> +					  "handover", "stop-ack",
> +					  "shutdown-ack";
> +
> +			clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
> +				 <&gcc GCC_BIMC_MSS_Q6_AXI_CLK>,
> +				 <&gcc GCC_BOOT_ROM_AHB_CLK>,
> +				 <&gcc GCC_MSS_GPLL0_DIV_CLK>,
Looks like this should be GPLL0_OUT_MMSSCC instead[1][2], this
clock is not defined upstream for some reason..

[1] https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.7.1.r1/arch/arm64/boot/dts/qcom/sdm660.dtsi#L1980
[2] https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.7.1.r1/drivers/clk/qcom/gcc-sdm660.c#L1756-L1770

Otherwise this looks good!

Konrad