From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH 0/2] iotests: Run pylint and mypy in a testcase
Date: Wed, 13 May 2020 16:56:14 -0400 [thread overview]
Message-ID: <e7d938ba-1862-ee88-cc74-8a1f0ea17d1c@redhat.com> (raw)
In-Reply-To: <20200511163529.349329-1-kwolf@redhat.com>
On 5/11/20 12:35 PM, Kevin Wolf wrote:
> Kevin Wolf (2):
> iotests: Fix incomplete type declarations
> iotests: Run pylint and mypy in a testcase
>
> tests/qemu-iotests/iotests.py | 8 +++----
> tests/qemu-iotests/297 | 44 +++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/297.out | 3 +++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 52 insertions(+), 4 deletions(-)
> create mode 100755 tests/qemu-iotests/297
> create mode 100644 tests/qemu-iotests/297.out
>
Cool!
Maybe the approach of putting this in 'make check' somewhere can
alleviate that expensive test being performed in iotests directly (as
Max notes), but, uhm. whatever.
For now, this will help prevent the backslide.
Reviewed-by: John Snow <jsnow@redhat.com>
prev parent reply other threads:[~2020-05-13 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:35 [PATCH 0/2] iotests: Run pylint and mypy in a testcase Kevin Wolf
2020-05-11 16:35 ` [PATCH 1/2] iotests: Fix incomplete type declarations Kevin Wolf
2020-05-13 11:57 ` Max Reitz
2020-05-11 16:35 ` [PATCH 2/2] iotests: Run pylint and mypy in a testcase Kevin Wolf
2020-05-13 12:14 ` Max Reitz
2020-05-13 14:54 ` Kevin Wolf
2020-05-13 20:56 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7d938ba-1862-ee88-cc74-8a1f0ea17d1c@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.