From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
dri-devel
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
amd-gfx mailing list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v5)
Date: Fri, 16 Jun 2017 10:28:08 +0200 [thread overview]
Message-ID: <e8021851-d630-3cbd-40e2-58f83a366a29@vodafone.de> (raw)
In-Reply-To: <CAPM=9twtavgA+D+vgZYz7UagnjxX6pGFBBUycCs2ofGjhOcBrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am 15.06.2017 um 05:59 schrieb Dave Airlie:
> On 1 June 2017 at 11:06, Dave Airlie <airlied@gmail.com> wrote:
>> From: Dave Airlie <airlied@redhat.com>
>>
>> This creates a new command submission chunk for amdgpu
>> to add in and out sync objects around the submission.
>>
>> Sync objects are managed via the drm syncobj ioctls.
>>
>> The command submission interface is enhanced with two new
>> chunks, one for syncobj pre submission dependencies,
>> and one for post submission sync obj signalling,
>> and just takes a list of handles for each.
>>
>> This is based on work originally done by David Zhou at AMD,
>> with input from Christian Konig on what things should look like.
>>
>> In theory VkFences could be backed with sync objects and
>> just get passed into the cs as syncobj handles as well.
>>
>> NOTE: this interface addition needs a version bump to expose
>> it to userspace.
>>
>> TODO: update to dep_sync when rebasing onto amdgpu master.
>> (with this - r-b from Christian)
> Hey Christian,
>
> did you have a chance to re-review this, I think this
> has the last changes you asked for done properly.
Sorry for the delay, holidays and dentist visits seem to eat up all my
time at the moment.
Patches #1-#3 in this series are Acked-by: Christian König
<christian.koenig@amd.com>.
Patch #4 already has my rb.
Patch #5 in this Series is Reviewed-by: Christian König
<christian.koenig@amd.com>.
> If so I'd like to get Alex to get drm-next + pull these in on top at some
> point, or if I already have the dep_sync changes in my tree I can just
> fix it up and apply them there.
Any approach works for me as long as Alex is fine with it.
Additional to your set I synced up two more ideas with out internal
Vulkan team which seem to make a lot of sense to upstream as well:
1. An IOCTL to reset a sync object to it's initial state. E.g. reset the
fence the sync objects wraps back to NULL.
2. The ability to merge multiple sync objects into one. Essentially the
same thing we have for the sync file, but handle based instead of fd.
I'm going to work on that in the next week or so. Shouldn't be to much
of a problem to come up with some sane code, but probably finding use
cases for this in the open source userspace might be challenging.
Regards,
Christian.
>
> Dave.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-06-16 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 1:06 drm syncobjs - running out of tag lines Dave Airlie
[not found] ` <20170601010643.28616-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-01 1:06 ` [PATCH 1/5] drm: introduce sync objects (v4) Dave Airlie
[not found] ` <20170601010643.28616-2-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-01 10:25 ` Chris Wilson
2017-06-01 1:06 ` [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v4) Dave Airlie
2017-06-01 10:57 ` Chris Wilson
2017-06-01 1:06 ` [PATCH 4/5] amdgpu/cs: split out fence dependency checking Dave Airlie
2017-06-01 1:06 ` [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v5) Dave Airlie
2017-06-15 3:59 ` Dave Airlie
[not found] ` <CAPM=9twtavgA+D+vgZYz7UagnjxX6pGFBBUycCs2ofGjhOcBrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-16 8:28 ` Christian König [this message]
[not found] ` <e8021851-d630-3cbd-40e2-58f83a366a29-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-06-17 1:23 ` Dave Airlie
2017-06-01 1:06 ` [PATCH 3/5] drm/syncobj: add sync_file interaction. (v1.2) Dave Airlie
[not found] ` <20170601010643.28616-4-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-01 10:58 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2017-05-29 7:30 drm-syncobj - mostly wait changes Dave Airlie
[not found] ` <20170529073033.10903-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-29 7:30 ` [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v5) Dave Airlie
[not found] ` <20170529073033.10903-6-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-29 12:04 ` Christian König
2017-05-24 7:06 drm syncobj - final posting I hope Dave Airlie
[not found] ` <20170524070615.1634-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-24 7:06 ` [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v5) Dave Airlie
[not found] ` <20170524070615.1634-6-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-24 7:25 ` zhoucm1
[not found] ` <5925355C.4080904-5C7GfCeVMHo@public.gmane.org>
2017-05-24 8:41 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8021851-d630-3cbd-40e2-58f83a366a29@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.