All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 3/9] btrfs: enable a tracepoint when we fail tickets
Date: Wed, 14 Jul 2021 14:47:19 -0400	[thread overview]
Message-ID: <e8840708de6be39bf0f34c5c3da2b52271546e37.1626288241.git.josef@toxicpanda.com> (raw)
In-Reply-To: <cover.1626288241.git.josef@toxicpanda.com>

When debugging early enospc problems it was useful to have a tracepoint
where we failed all tickets so I could check the state of the enospc
counters at failure time to validate my fixes.  This adds the tracpoint
so you can easily get that information.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 fs/btrfs/space-info.c        | 2 ++
 include/trace/events/btrfs.h | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
index 392997376a1c..af161eb808a2 100644
--- a/fs/btrfs/space-info.c
+++ b/fs/btrfs/space-info.c
@@ -825,6 +825,8 @@ static bool maybe_fail_all_tickets(struct btrfs_fs_info *fs_info,
 	struct reserve_ticket *ticket;
 	u64 tickets_id = space_info->tickets_id;
 
+	trace_btrfs_fail_all_tickets(fs_info, space_info);
+
 	if (btrfs_test_opt(fs_info, ENOSPC_DEBUG)) {
 		btrfs_info(fs_info, "cannot satisfy tickets, dumping space info");
 		__btrfs_dump_space_info(fs_info, space_info);
diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index a87953e74573..d754c6ec1797 100644
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -2104,6 +2104,12 @@ DEFINE_EVENT(btrfs_dump_space_info, btrfs_done_preemptive_reclaim,
 	TP_ARGS(fs_info, sinfo)
 );
 
+DEFINE_EVENT(btrfs_dump_space_info, btrfs_fail_all_tickets,
+	TP_PROTO(struct btrfs_fs_info *fs_info,
+		 const struct btrfs_space_info *sinfo),
+	TP_ARGS(fs_info, sinfo)
+);
+
 TRACE_EVENT(btrfs_reserve_ticket,
 	TP_PROTO(const struct btrfs_fs_info *fs_info, u64 flags, u64 bytes,
 		 u64 start_ns, int flush, int error),
-- 
2.26.3


  parent reply	other threads:[~2021-07-14 18:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 18:47 [PATCH v3 0/9] ENOSPC delalloc flushing fixes Josef Bacik
2021-07-14 18:47 ` [PATCH v3 1/9] btrfs: wake up async_delalloc_pages waiters after submit Josef Bacik
2021-07-14 18:47 ` [PATCH v3 2/9] btrfs: include delalloc related info in dump space info tracepoint Josef Bacik
2021-07-14 18:47 ` Josef Bacik [this message]
2021-07-14 18:47 ` [PATCH v3 4/9] btrfs: handle shrink_delalloc pages calculation differently Josef Bacik
2021-07-14 18:47 ` [PATCH v3 5/9] btrfs: wait on async extents when flushing delalloc Josef Bacik
2021-07-14 18:47 ` [PATCH v3 6/9] fs: add a filemap_fdatawrite_wbc helper Josef Bacik
2021-07-15  6:23   ` Christoph Hellwig
2021-07-21 11:20     ` David Sterba
2021-07-14 18:47 ` [PATCH v3 7/9] btrfs: use the filemap_fdatawrite_wbc helper for delalloc shrinking Josef Bacik
2021-07-14 18:47 ` [PATCH v3 8/9] 9p: migrate from sync_inode to filemap_fdatawrite_wbc Josef Bacik
2021-07-15  6:25   ` Christoph Hellwig
2021-07-21 10:49   ` David Sterba
2021-07-14 18:47 ` [PATCH v3 9/9] fs: kill sync_inode Josef Bacik
2021-07-15  6:27   ` Christoph Hellwig
2021-07-15  7:31 ` [PATCH v3 0/9] ENOSPC delalloc flushing fixes Nikolay Borisov
2021-07-21 11:29 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8840708de6be39bf0f34c5c3da2b52271546e37.1626288241.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.