From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Laurent Vivier <laurent@vivier.eu>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 0/5] Linux user for 6.0 patches
Date: Thu, 21 Jan 2021 12:38:10 +0100 [thread overview]
Message-ID: <e8d3abb0-9992-e991-6f54-d138d1190b76@amsat.org> (raw)
In-Reply-To: <a3565e8c-1e4e-6544-1784-37a5d2cd33ab@vivier.eu>
On 1/21/21 12:07 PM, Laurent Vivier wrote:
> Le 21/01/2021 à 11:44, Peter Maydell a écrit :
>> On Wed, 20 Jan 2021 at 19:56, Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>> The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506:
>>>
>>> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011=
>>> 9-1' into staging (2021-01-19 15:47:23 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request
>>>
>>> for you to fetch changes up to 8a7e49050b8d5477a567b0ec5d764a564481abdb:
>>>
>>> linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-20 18:=
>>> 26:46 +0100)
>>>
>>> ----------------------------------------------------------------
>>> linux-user pull request 20210119-v2
>>>
>>> Remove obsolete F_SHLCK and F_EXLCK translation
>>> Update sockopt
>>> Add F_ADD_SEALS and F_GET_SEALS
>>>
>> Now fails with:
>>
>> ../../linux-user/strace.c: In function ‘do_print_sockopt’:
>> ../../linux-user/strace.c:2831:14: error: ‘IPV6_ADDR_PREFERENCES’
>> undeclared (first use in this function)
>> case IPV6_ADDR_PREFERENCES:
I checked on CentOS7 and this part isn't compiled because
TARGET_NR_socketcall is not defined, but I only build the
x86_64-linux-user target there.
>
> Probably the same cause, in a different file.
>
> This should fix the problem.
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index bc3bb6b2f949..7b43668b9b0e 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -11,6 +11,7 @@
> #include <netinet/udp.h>
> #include <linux/if_packet.h>
> #include <linux/netlink.h>
> +#include <linux/in6.h>
> #include <sched.h>
> #include "qemu.h"
Sounds good.
>
> I will try to reproduce it before re-sending the PR.
>
> Thanks,
> Laurent
>
next prev parent reply other threads:[~2021-01-21 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 19:53 [PULL 0/5] Linux user for 6.0 patches Laurent Vivier
2021-01-20 19:53 ` [PULL 1/5] linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls Laurent Vivier
2021-01-20 19:53 ` [PULL 2/5] linux-user: add missing UDP get/setsockopt option Laurent Vivier
2021-01-20 19:53 ` [PULL 3/5] linux-user: add missing IPv6 " Laurent Vivier
2021-01-20 19:53 ` [PULL 4/5] linux-user: Add IPv6 options to do_print_sockopt() Laurent Vivier
2021-01-20 19:53 ` [PULL 5/5] linux-user: Remove obsolete F_SHLCK and F_EXLCK translation Laurent Vivier
2021-01-21 10:44 ` [PULL 0/5] Linux user for 6.0 patches Peter Maydell
2021-01-21 11:07 ` Laurent Vivier
2021-01-21 11:38 ` Philippe Mathieu-Daudé [this message]
2021-01-21 11:43 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2021-03-13 9:47 Laurent Vivier
2021-03-13 9:57 ` no-reply
2021-03-14 19:15 ` Peter Maydell
2021-01-21 12:38 Laurent Vivier
2021-01-22 13:11 ` Peter Maydell
2021-01-19 17:54 Laurent Vivier
2021-01-20 14:23 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8d3abb0-9992-e991-6f54-d138d1190b76@amsat.org \
--to=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.