From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dikshita Agarwal <quic_dikshita@quicinc.com>,
Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dikshita Agarwal <dikshita@qti.qualcomm.com>,
Dikshita Agarwal <dikshita@codeaurora.org>,
Mansur Alisha Shaik <mansur@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vikash Garodia <vgarodia@codeaurora.org>
Subject: Re: [PATCH 01/18] media: venus: hfi_venus: Set venus_sys_idle_indicator to false on V6
Date: Thu, 2 Mar 2023 12:33:58 +0100 [thread overview]
Message-ID: <e95ce32e-60cb-f892-804f-686472657376@linaro.org> (raw)
In-Reply-To: <28b0eed5-6e80-e424-70bb-ba984fdbc1ac@quicinc.com>
On 2.03.2023 07:39, Dikshita Agarwal wrote:
>
> On 2/28/2023 10:23 PM, Bryan O'Donoghue wrote:
>> On 28/02/2023 15:41, Konrad Dybcio wrote:
>>>> Can you test it and make sure ?
>>> As I mentioned in the cover letter, 8250 still seems to work with this
>>> patchset. I have no idea how one would go about validating the
>>> functionality enabled through this call.
>>
>> We offlined about this.
>>
>> I think it is correct to say you don't have access to a display to test this on sm8250.
>>
>> I do so, I will try this out for you, though I'll wait for your V2 for this series.
>>
>> ---
>> bod
>
> Hi Konrad,
>
> I understand from your commit text, setting this indicator for AR50L is causing issue with suspend.
>
> Ideally it shouldn't cause any such issue. I checked with FW team and got to know that this property is not supported on AR50LT so if you set it there should be some property not supported error.
>
> In my opinion it would be good to replace these versions checks with VPU version check you have introduced in your other patch and keep this setting for current targets and not set wherever not needed eg AR50LT.
Okay, I have two questions then:
1. Can the firmware team confirm it shouldn't crash on a fw tag
that's close to VIDEO.VE.6.0-00042-PROD-1?
2. Are there any other SoCs that SYS_IDLE is not supported on?
It hasn't been sent to the hardware by the vidc driver for
any SoC using the downstream vidc (NOT the legacy vidc_3x)
driver starting with msm-4.14, AFAICS.. check out this link:
https://github.com/sonyxperiadev/kernel/commit/8889a7d26943e96eae2f318f87b15efa4b907f28
Konrad
>
> Thanks,
>
> Dikshita
>
next prev parent reply other threads:[~2023-03-02 11:34 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 15:24 [PATCH 00/18] Venus QoL / maintainability fixes Konrad Dybcio
2023-02-28 15:24 ` [PATCH 01/18] media: venus: hfi_venus: Set venus_sys_idle_indicator to false on V6 Konrad Dybcio
2023-02-28 15:26 ` Bryan O'Donoghue
2023-02-28 15:31 ` Bryan O'Donoghue
2023-02-28 15:37 ` Konrad Dybcio
2023-02-28 15:38 ` Bryan O'Donoghue
2023-02-28 15:41 ` Konrad Dybcio
2023-02-28 16:53 ` Bryan O'Donoghue
2023-03-02 6:39 ` Dikshita Agarwal
2023-03-02 11:33 ` Konrad Dybcio [this message]
2023-03-02 11:54 ` Dikshita Agarwal
2023-03-20 14:54 ` Konrad Dybcio
[not found] ` <e93ba74a-ccde-c6bd-4302-8884144d615d@quicinc.com>
[not found] ` <bf5e30fa-5014-5585-3b8e-b1a8d2f95549@quicinc.com>
2023-04-04 17:52 ` Konrad Dybcio
2023-02-28 15:24 ` [PATCH 02/18] media: venus: Introduce VPU version distinction Konrad Dybcio
2023-03-02 7:12 ` Dikshita Agarwal
2023-03-02 11:37 ` Konrad Dybcio
2023-03-30 11:02 ` Vikash Garodia
2023-03-30 11:15 ` Konrad Dybcio
2023-02-28 15:24 ` [PATCH 03/18] media: venus: Add vpu_version to most SoCs Konrad Dybcio
2023-02-28 15:24 ` [PATCH 04/18] media: venus: firmware: Leave a clue for homegrown porters Konrad Dybcio
2023-03-02 8:18 ` Dikshita Agarwal
2023-02-28 15:24 ` [PATCH 05/18] media: venus: hfi_venus: Sanitize venus_boot_core() per-VPU-version Konrad Dybcio
2023-03-02 11:00 ` Dikshita Agarwal
2023-03-02 11:10 ` Konrad Dybcio
2023-03-02 11:58 ` Dikshita Agarwal
2023-02-28 15:24 ` [PATCH 06/18] media: venus: hfi_venus: Write to VIDC_CTRL_INIT after unmasking interrupts Konrad Dybcio
2023-02-28 15:33 ` Bryan O'Donoghue
2023-02-28 15:59 ` Konrad Dybcio
2023-03-02 12:27 ` Dikshita Agarwal
2023-02-28 15:24 ` [PATCH 07/18] media: venus: core: Assign registers based on VPU version Konrad Dybcio
2023-03-07 4:57 ` Dikshita Agarwal
2023-03-07 11:18 ` Konrad Dybcio
2023-02-28 15:24 ` [PATCH 08/18] media: venus: hfi_venus: Fix version checks in venus_halt_axi() Konrad Dybcio
2023-02-28 15:36 ` Bryan O'Donoghue
2023-02-28 16:01 ` Konrad Dybcio
2023-03-02 12:35 ` Dikshita Agarwal
2023-02-28 15:24 ` [PATCH 09/18] media: venus: hfi_venus: Fix version checks in venus_isr() Konrad Dybcio
2023-03-07 6:12 ` Dikshita Agarwal
2023-03-07 6:14 ` Dikshita Agarwal
2023-02-28 15:24 ` [PATCH 10/18] media: venus: hfi_venus: Fix version check in venus_cpu_and_video_core_idle() Konrad Dybcio
2023-02-28 15:40 ` Bryan O'Donoghue
2023-02-28 15:24 ` [PATCH 11/18] media: venus: hfi_venus: Fix version check in venus_cpu_idle_and_pc_ready() Konrad Dybcio
2023-02-28 15:24 ` [PATCH 12/18] media: venus: firmware: Correct IS_V6() checks Konrad Dybcio
2023-02-28 15:48 ` Bryan O'Donoghue
2023-02-28 16:08 ` Konrad Dybcio
2023-02-28 15:24 ` [PATCH 13/18] media: venus: hfi_platform: Check vpu_version instead of device compatible Konrad Dybcio
2023-02-28 15:49 ` Bryan O'Donoghue
2023-02-28 15:24 ` [PATCH 14/18] media: venus: vdec: Fix version check in vdec_set_work_route() Konrad Dybcio
2023-02-28 15:50 ` Bryan O'Donoghue
2023-02-28 15:24 ` [PATCH 15/18] media: venus: Remap bufreq fields on HFI6XX Konrad Dybcio
2023-02-28 15:51 ` Bryan O'Donoghue
2023-02-28 16:05 ` Konrad Dybcio
2023-02-28 15:24 ` [PATCH 16/18] media: venus: Introduce accessors for remapped hfi_buffer_reqs members Konrad Dybcio
2023-02-28 15:54 ` Bryan O'Donoghue
2023-02-28 15:24 ` [PATCH 17/18] media: venus: Use newly-introduced hfi_buffer_requirements accessors Konrad Dybcio
2023-02-28 15:56 ` Bryan O'Donoghue
2023-02-28 16:09 ` Konrad Dybcio
2023-02-28 15:24 ` [PATCH 18/18] media: venus: hfi_venus: Restrict writing SCIACMDARG3 to Venus V1/V2 Konrad Dybcio
2023-02-28 15:57 ` Bryan O'Donoghue
2023-02-28 16:09 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e95ce32e-60cb-f892-804f-686472657376@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dikshita@codeaurora.org \
--cc=dikshita@qti.qualcomm.com \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.