Re: [PATCH 6/9] nilfs2: fix out-of-range warning

From: "Arnd Bergmann" <arnd@arndb.de>
To: "Philipp Stanner" <pstanner@redhat.com>,
	"Arnd Bergmann" <arnd@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
	"Nathan Chancellor" <nathan@kernel.org>
Cc: "Nick Desaulniers" <ndesaulniers@google.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jeff Layton" <jlayton@kernel.org>,
	"Thorsten Blum" <thorsten.blum@toblux.com>,
	linux-nilfs@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 6/9] nilfs2: fix out-of-range warning
Date: Thu, 28 Mar 2024 17:12:03 +0100	[thread overview]
Message-ID: <e96b89e1-0fd7-44c1-a0ed-cd40a5e7af67@app.fastmail.com> (raw)
In-Reply-To: <25b5f2297c98500ed91971a61ccc4bfa5921035e.camel@redhat.com>

On Thu, Mar 28, 2024, at 16:21, Philipp Stanner wrote:
> On Thu, 2024-03-28 at 15:30 +0100, Arnd Bergmann wrote:
>> 
>> This is ok, so just shut up that warning with a cast.
>
> nit:
> It's not a warning, but actually a compile error, right?

I build with CONFIG_WERROR=y, which turns all warnings
into errors. It's just a warning without that, and is
currently only enabled when building with 'make W=1',
though the point of my series is to have it always enabled.

> (no idea why they make that an error btw. Warning would be perfectly
> fine)
>
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Should / could that be backported to stable kernels in case people
> start building those with clang-14?

It's clearly harmless and could be backported, but it
is not needed either since older kernels will keep the
option as part of W=1, not the default.

      Arnd