All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Melody Olvera <quic_molvera@quicinc.com>,
	Vinod Koul <vkoul@kernel.org>,
	Richard Acayan <mailingradian@gmail.com>,
	Lina Iyer <ilina@codeaurora.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Abel Vesa <abel.vesa@linaro.org>,
	Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Luca Weiss <luca.weiss@fairphone.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Maulik Shah <quic_mkshah@quicinc.com>,
	Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH 0/8] Flush RSC votes properly on more RPMh platforms
Date: Thu, 1 Jun 2023 10:15:13 +0200	[thread overview]
Message-ID: <e98a2901-7ad4-5a1f-5739-64750836d396@linaro.org> (raw)
In-Reply-To: <CAD=FV=Um8U2MQsrv+ngQg_h-aQMi5_yy6Lrj3ovr7eV1PC+Wnw@mail.gmail.com>



On 31.05.2023 23:45, Doug Anderson wrote:
> Hi,
> 
> On Wed, May 31, 2023 at 7:26 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On 31.05.2023 15:22, Konrad Dybcio wrote:
>>> As pointed out in [1], the Linux implementation of RSC basically requires
>>> (even if not explicitly) that we point it to a power domain which
>>> represents the power state of the CPUs. In an effort to fulfill that
>>> requirement, make it required in bindings and hook it up on all platforms
>>> where I was able to do. This means all RPMh platforms, except
>>>
>>> - SC7180
>>> - SC7280
>>> - SA8775
>>>
>>> As there wasn't an idle-states setup (which may be on purpose for CrOS
>>> devices, certainly not for Windows SC7[12]80s) that I could validate.
>>> (Doug, Bartosz, could you guys look into your respective platforms of
>>> interest here?)
>>>
>>> This series also adds support for idle states on SM6350, as I was able
>>> to add and test that.
>> I noticed that 7280 is WIP:
>>
>> https://lore.kernel.org/lkml/20230424110933.3908-4-quic_mkshah@quicinc.com/
> 
> Right. For sc7180 Chromebooks we don't use OSI (OS Initiated) mode but
> instead use PC (Platform Coordinated) mode. As I understand it, that
> means we take a different path through all this stuff.
> 
> That being said, in the sc7280 thread you pointed at, Bjorn and Ulf
> said that we could use the new device tree snippets for sc7280 even
> before the ATF update. If I'm reading the thread correctly and the
> same applies to sc7180:
> 
> 1. New DT plus firmware that doesn't support OSI - OK
> 2. New DT plus firmware that supports OSI - OK after code changes
> 3. Old DT plus firmware that doesn't support OSI - OK
> 4. Old DT plus firmware that supports OSI - Not OK
> 
> For sc7180 Chromebooks we'll never have firmware that supports OSI.
> That means that, assuming I'm understanding correctly, we actually
> could move the DT to represent things the new way. Presumably this
> would be important for sc7180 devices that originally shipped with
> Windows (I think support for one of these is underway).
It's even merged now!

Yeah, AFAICT all you said makes sense

I don't however know how you tell RSC driver that your platform is
going to sleep when using PC mode..

KOnrad
> 
> -Doug

  reply	other threads:[~2023-06-01  8:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 13:22 [PATCH 0/8] Flush RSC votes properly on more RPMh platforms Konrad Dybcio
2023-05-31 13:22 ` [PATCH 1/8] dt-bindings: soc: qcom,rpmh-rsc: Require power-domains Konrad Dybcio
2023-06-01  6:50   ` Krzysztof Kozlowski
2023-05-31 13:22 ` [PATCH 2/8] arm64: dts: qcom: sm6350: Add PSCI idle states Konrad Dybcio
2023-05-31 13:22 ` [PATCH 3/8] arm64: dts: qcom: qdu1000: Flush RSC sleep & wake votes Konrad Dybcio
2023-05-31 13:22 ` [PATCH 4/8] arm64: dts: qcom: sc8180x: " Konrad Dybcio
2023-05-31 13:22 ` [PATCH 5/8] arm64: dts: qcom: sdm670: " Konrad Dybcio
2023-05-31 13:22 ` [PATCH 6/8] arm64: dts: qcom: sdm845: " Konrad Dybcio
2023-05-31 13:22 ` [PATCH 7/8] arm64: dts: qcom: sm6350: " Konrad Dybcio
2023-05-31 13:22 ` [PATCH 8/8] arm64: dts: qcom: sm8550: " Konrad Dybcio
2023-05-31 14:25 ` [PATCH 0/8] Flush RSC votes properly on more RPMh platforms Konrad Dybcio
2023-05-31 14:25 ` Konrad Dybcio
2023-05-31 21:45   ` Doug Anderson
2023-06-01  8:15     ` Konrad Dybcio [this message]
2023-06-13 22:30 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e98a2901-7ad4-5a1f-5739-64750836d396@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=ilina@codeaurora.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mailingradian@gmail.com \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_mkshah@quicinc.com \
    --cc=quic_molvera@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.