From: Mark Brown <broonie@kernel.org>
To: Karel Balej <balejk@matfyz.cz>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC
Date: Thu, 21 Mar 2024 17:48:28 +0000 [thread overview]
Message-ID: <e9c7bd38-49cd-44c2-8842-292bc0b4205f@sirena.org.uk> (raw)
In-Reply-To: <CZZLVS3T3QIS.223XHI5OZ7UBG@matfyz.cz>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote:
> Mark Brown, 2024-03-21T17:17:40+00:00:
> > Do they both genuinely have the same maximum register?
> They do according to the downstream driver which is my only reference.
> In fact, there the driver defines the configs separately for each regmap
> but with the same values.
This is a downstream driver - are you sure it's got the best code
quality? I'm not seeing any references to registers with numbers as
high as the maximum register that's there in your driver for example.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-21 17:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 15:51 [RFC PATCH v4 0/5] initial support for Marvell 88PM886 PMIC Karel Balej
2024-03-11 15:51 ` [RFC PATCH v4 1/5] dt-bindings: mfd: add entry " Karel Balej
2024-03-11 15:51 ` [RFC PATCH v4 2/5] mfd: add driver " Karel Balej
2024-03-21 15:42 ` Lee Jones
2024-03-21 16:12 ` Karel Balej
2024-03-21 16:20 ` Lee Jones
2024-03-21 16:55 ` Karel Balej
2024-03-21 16:58 ` Mark Brown
2024-03-21 17:08 ` Karel Balej
2024-03-21 17:17 ` Mark Brown
2024-03-21 17:32 ` Karel Balej
2024-03-21 17:48 ` Mark Brown [this message]
2024-03-21 18:16 ` Karel Balej
2024-03-21 19:00 ` Mark Brown
2024-03-21 19:14 ` Karel Balej
2024-03-21 19:32 ` Mark Brown
2024-03-11 15:51 ` [RFC PATCH v4 3/5] regulator: add regulators " Karel Balej
2024-03-11 15:51 ` [RFC PATCH v4 4/5] input: add onkey " Karel Balej
2024-03-11 15:51 ` [RFC PATCH v4 5/5] MAINTAINERS: add myself " Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c7bd38-49cd-44c2-8842-292bc0b4205f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=balejk@matfyz.cz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=duje.mihanovic@skole.hr \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.