From: Felipe Balbi <me@felipebalbi.com>
To: "Olaya, Margarita" <magi.olaya@ti.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 1/2] OMAP4: PMIC: Rename twl6030_codec as twl6040_codec
Date: Sat, 13 Mar 2010 05:17:36 -0600 [thread overview]
Message-ID: <ea13b3e438eb2455f4d0d91396f2500e@secure211.sgcpanel.com> (raw)
In-Reply-To: <1889FA7136B567478A67D4B0F85B0CCE66173AF6@dlee06.ent.ti.com>
Hi,
On Fri, 12 Mar 2010 19:52:15 -0600, "Olaya, Margarita" <magi.olaya@ti.com>
wrote:
please add a description here. Why do you need to rename it ?
> Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>
[snip]
> @@ -708,7 +708,7 @@ add_children(struct twl4030_platform_data *pdata,
> unsigned long features)
> /* Phoenix*/
> if (twl_has_codec() && pdata->codec && twl_class_is_6030()) {
> sub_chip_id = twl_map[TWL_MODULE_AUDIO_VOICE].sid;
> - child = add_child(sub_chip_id, "twl6030_codec",
> + child = add_child(sub_chip_id, "twl6040_codec",
you rename the platform_device but no the platform_driver ??
how do you expect the driver to probe() ??
--
balbi
next prev parent reply other threads:[~2010-03-13 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 1:52 [PATCH 1/2] OMAP4: PMIC: Rename twl6030_codec as twl6040_codec Olaya, Margarita
2010-03-13 11:17 ` Felipe Balbi [this message]
2010-03-16 17:35 ` Olaya, Margarita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea13b3e438eb2455f4d0d91396f2500e@secure211.sgcpanel.com \
--to=me@felipebalbi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=magi.olaya@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.