Re: [PATCH] drm/i915/uc: Make intel_uc_prepare_fw() static

From: Oscar Mateo <oscar.mateo@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/uc: Make intel_uc_prepare_fw() static
Date: Mon, 20 Mar 2017 10:17:48 -0700	[thread overview]
Message-ID: <ea8e7c8b-ee1d-c930-2ae8-5026ed1e149c@intel.com> (raw)
In-Reply-To: <20170315193819.155416-1-michal.wajdeczko@intel.com>


On 03/15/2017 12:38 PM, Michal Wajdeczko wrote:
> There is no need to expose this function as it is called from
> one function only. Also move it up to avoid forward declaration.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uc.c | 269 ++++++++++++++++++++--------------------
>   drivers/gpu/drm/i915/intel_uc.h |   2 -
>   2 files changed, 135 insertions(+), 136 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index 54c5aff..a0d8833 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -86,6 +86,141 @@ void intel_uc_init_early(struct drm_i915_private *dev_priv)
>   	mutex_init(&dev_priv->guc.send_mutex);
>   }
>   
> +static void intel_uc_prepare_fw(struct drm_i915_private *dev_priv,
> +				struct intel_uc_fw *uc_fw)
> +{
> +	struct pci_dev *pdev = dev_priv->drm.pdev;
>
No need for prefix intel_*, since it's a static function?

-- Oscar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx