From: Jens Axboe <axboe@kernel.dk>
To: Yuanchu Xie <yuanchu@google.com>,
Vincent Fu <vincentfu@gmail.com>,
fio@vger.kernel.org
Cc: Yu Zhao <yuzhao@google.com>, "T . J . Alumbaugh" <talumbau@google.com>
Subject: Re: [PATCH v2 1/2] fio: add support for POSIX_FADV_NOREUSE
Date: Fri, 31 Mar 2023 12:54:39 -0600 [thread overview]
Message-ID: <eb82cb58-6f0f-81d0-79e0-714c5a5ee6b1@kernel.dk> (raw)
In-Reply-To: <dd139789-17e2-f99e-9362-40a266782719@kernel.dk>
On 3/31/23 12:41 PM, Jens Axboe wrote:
> On 3/31/23 12:37 PM, Yuanchu Xie wrote:
>> As of Linux kernel commit 17e810229cb3 ("mm: support
>> POSIX_FADV_NOREUSE"), POSIX_FADV_NOREUSE hints at the LRU algorithm to
>> ignore accesses to mapped files with this flag. Previously, it was a
>> no-op.
>>
>> Add it in fio as an fadvise_hint option to test the new behavior.
>
> I just applied this, but then I pondered if we'll be breaking normal
> installs that don't have POSIX_FADV_NOREUSE available? Maybe the
> libc define predates the kernel actually implementing it by long
> enough that this doesn't matter? Let's see what happens...
Somewhat unsurprisingly, this did break the build on OSX. I added
a patch to make it conditionally available.
--
Jens Axboe
next prev parent reply other threads:[~2023-03-31 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 18:37 [PATCH v2 1/2] fio: add support for POSIX_FADV_NOREUSE Yuanchu Xie
2023-03-31 18:37 ` [PATCH v2 2/2] docs: add noreuse fadvise_hint option Yuanchu Xie
2023-03-31 18:41 ` [PATCH v2 1/2] fio: add support for POSIX_FADV_NOREUSE Jens Axboe
2023-03-31 18:54 ` Jens Axboe [this message]
2023-03-31 18:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb82cb58-6f0f-81d0-79e0-714c5a5ee6b1@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=talumbau@google.com \
--cc=vincentfu@gmail.com \
--cc=yuanchu@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.