From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the HP Pro Tablet 408
Date: Wed, 27 Apr 2022 10:52:59 -0500 [thread overview]
Message-ID: <ec01bea7-3757-b891-00d4-2ad6520e2ab5@linux.intel.com> (raw)
In-Reply-To: <20220427134918.527381-1-hdegoede@redhat.com>
On 4/27/22 08:49, Hans de Goede wrote:
> Add a quirk for the HP Pro Tablet 408, this BYTCR tablet has no CHAN
> package in its ACPI tables and uses SSP0-AIF1 rather then SSP0-AIF2 which
> is the default for BYTCR devices.
>
> It also uses DMIC1 for the internal mic rather then the default IN3
> and it uses JD2 rather then the default JD1 for jack-detect.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=211485
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Hans!
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index d76a505052fb..f81ae742faa7 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -773,6 +773,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_OVCD_SF_0P75 |
> BYT_RT5640_MCLK_EN),
> },
> + { /* HP Pro Tablet 408 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pro Tablet 408"),
> + },
> + .driver_data = (void *)(BYT_RT5640_DMIC1_MAP |
> + BYT_RT5640_JD_SRC_JD2_IN4N |
> + BYT_RT5640_OVCD_TH_1500UA |
> + BYT_RT5640_OVCD_SF_0P75 |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> + },
> { /* HP Stream 7 */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
next prev parent reply other threads:[~2022-04-27 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 13:49 [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the HP Pro Tablet 408 Hans de Goede
2022-04-27 15:52 ` Pierre-Louis Bossart [this message]
2022-04-28 15:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec01bea7-3757-b891-00d4-2ad6520e2ab5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.