From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Brown <broonie@kernel.org>,
YANG LI <abaci-bugfix@linux.alibaba.com>,
kdasu.kdev@gmail.com
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison
Date: Mon, 11 Jan 2021 08:41:19 -0800 [thread overview]
Message-ID: <ec735a59-0fbd-3d4a-e997-895099a8e534@gmail.com> (raw)
In-Reply-To: <161038255869.32886.11006261963964555197.b4-ty@kernel.org>
On 1/11/2021 8:29 AM, Mark Brown wrote:
> On Mon, 11 Jan 2021 17:26:29 +0800, YANG LI wrote:
>> Fix the following coccicheck warning:
>> ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!
>
> [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
> commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8
I don't think that "style: " is a subject prefix that is used commonly
and it certainly should not belong in a commit subject. Mark can you
please people at least 10-12 hours to review changes before applying
them? This one is trivial except the commit subject does not match
previous changes done to this file and it should have been fixed.
--
Florian
next prev parent reply other threads:[~2021-01-11 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:26 [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison YANG LI
2021-01-11 16:29 ` Mark Brown
2021-01-11 16:41 ` Florian Fainelli [this message]
2021-01-11 17:05 ` Mark Brown
2021-01-11 17:21 ` Florian Fainelli
2021-01-11 17:29 ` Mark Brown
2021-01-11 9:54 YANG LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec735a59-0fbd-3d4a-e997-895099a8e534@gmail.com \
--to=f.fainelli@gmail.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.