From: Hui Wang <hui.wang@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com
Subject: Re: [PATCH v7 1/1] alsa: jack: implement software jack injection via debugfs
Date: Tue, 26 Jan 2021 14:55:29 +0800 [thread overview]
Message-ID: <ecb8450b-c7be-52ff-e6f2-876c2177cb21@canonical.com> (raw)
In-Reply-To: <s5ha6sx3x5i.wl-tiwai@suse.de>
On 1/25/21 10:32 PM, Takashi Iwai wrote:
> On Mon, 25 Jan 2021 04:21:18 +0100,
> Hui Wang wrote:
>> This change adds audio jack injection feature through debugfs, with
>> this feature, we could validate alsa userspace changes by injecting
>> plugin or plugout events to the non-phantom audio jacks.
>>
>> With this change, the sound core will build the folders
>> $debugfs_mount_dir/sound/cardN if SND_DEBUG and DEBUG_FS are enabled.
<snip>
>> + return -ENOMEM;
>> +
>> + /* replace the chars which are not suitable for folder's name with _ */
>> + for (i = 0; i < strlen(tname); i++)
> No need to use strlen(), just check the NUL character on tname[i].
OK, will change it to: for (i = 0; tname[i] != '\0'; i++)
>
>> --- a/sound/core/sound.c
>> +++ b/sound/core/sound.c
>> @@ -9,6 +9,7 @@
>> #include <linux/time.h>
>> #include <linux/device.h>
>> #include <linux/module.h>
>> +#include <linux/debugfs.h>
>> #include <sound/core.h>
>> #include <sound/minors.h>
>> #include <sound/info.h>
>> @@ -39,6 +40,9 @@ MODULE_ALIAS_CHARDEV_MAJOR(CONFIG_SND_MAJOR);
>> int snd_ecards_limit;
>> EXPORT_SYMBOL(snd_ecards_limit);
>>
>> +struct dentry *sound_debugfs_root;
>> +EXPORT_SYMBOL_GPL(sound_debugfs_root);
> I guess this should be wrapped with CONFIG_SND_DEBUG ifdef?
OK, will add the wrap.
thanks,
Hui.
>
>
> thanks,
>
> Takashi
next prev parent reply other threads:[~2021-01-26 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 3:21 [PATCH v7 0/1] audio jack software injection Hui Wang
2021-01-25 3:21 ` [PATCH v7 1/1] alsa: jack: implement software jack injection via debugfs Hui Wang
2021-01-25 14:32 ` Takashi Iwai
2021-01-26 6:55 ` Hui Wang [this message]
2021-01-26 6:58 ` Takashi Iwai
2021-01-26 7:03 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb8450b-c7be-52ff-e6f2-876c2177cb21@canonical.com \
--to=hui.wang@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.