From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <iwj@xenproject.org>,
Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, <wl@xen.org>,
<anthony.perard@citrix.com>, <tamas.k.lengyel@gmail.com>
Subject: Re: [PATCH v2 2/2] tools/libxl: only set viridian flags on new domains
Date: Fri, 5 Feb 2021 18:59:22 +0000 [thread overview]
Message-ID: <ecdd0986-bf35-4bc8-71a4-3fc23e42d163@citrix.com> (raw)
In-Reply-To: <24605.37516.737667.412159@mariner.uk.xensource.com>
On 05/02/2021 18:46, Ian Jackson wrote:
> Igor Druzhinin writes ("[PATCH v2 2/2] tools/libxl: only set viridian flags on new domains"):
>> Domains migrating or restoring should have viridian HVM param key in
>> the migration stream already and setting that twice results in Xen
>> returing -EEXIST on the second attempt later (during migration stream parsing)
>> in case the values don't match. That causes migration/restore operation
>> to fail at destination side.
>>
>> That issue is now resurfaced by the latest commits (983524671 and 7e5cffcd1e)
>> extending default viridian feature set making the values from the previous
>> migration streams and those set at domain construction different.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> Thanks for splitting this up.
>
> Release-Acked-by: Ian Jackson <iwj@xenproject.org>
>
> Andy, I think from irc that this meets with your approval but can I
> have a formal R-b ? If so please put my tools maintainer ack on it
> too.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2021-02-05 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 20:07 [PATCH v2 1/2] tools/libxl: pass libxl__domain_build_state to libxl__arch_domain_create Igor Druzhinin
2021-02-03 20:07 ` [PATCH v2 2/2] tools/libxl: only set viridian flags on new domains Igor Druzhinin
2021-02-05 18:46 ` Ian Jackson
2021-02-05 18:59 ` Andrew Cooper [this message]
2021-02-05 18:45 ` [PATCH v2 1/2] tools/libxl: pass libxl__domain_build_state to libxl__arch_domain_create Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecdd0986-bf35-4bc8-71a4-3fc23e42d163@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=iwj@xenproject.org \
--cc=tamas.k.lengyel@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.