* [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS
@ 2021-03-30 16:44 Lee Jones
2021-03-30 16:44 ` [PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc Lee Jones
` (13 more replies)
0 siblings, 14 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andreas Gruenbacher, Andrew Morton, Bob Peterson,
Christian Brauner, cluster-devel, David Howells, ecryptfs,
Eric Biggers, James Morris, Johannes Weiner, Michael A. Halcrow,
Michael A. Halcrow, Michael C. Thompsion, Michal Hocko,
Trevor S. Highland, Tycho Andersen, Tyler Hicks, Waiman Long
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
There is more to do in filesystems. Another set will follow.
Lee Jones (31):
fs: gfs2: dir: Finish off mostly complete headers demote others
fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant
ones
fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others
fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote
others
fs: gfs2: log: Fix a couple of param descriptions and demote
non-conformant headers
fs: gfs2: lops: Help out worthy kernel-doc headers and demote others
fs: gfs2: glock: Fix some deficient kernel-doc headers and demote
non-conformant ones
fs: gfs2: aops: Fix a little potential doc-rot
fs: gfs2: meta_io: Add missing description for 'rahead' param
fs: gfs2: inode: Fix worthy function headers demote others
fs: gfs2: file: Strip out superfluous param description and demote
kernel-doc abuse
fs: gfs2: ops_fstype: Fix a little doc-rot
fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad'
fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours
fs: gfs2: recovery: Provide missing param descriptions and remove one
other
fs: gfs2: super: Fix kernel-doc issues where feasible demote one other
fs: gfs2: util: Fix one conformant kernel-doc header and demote a
bunch of abuses
fs: gfs2: lock_dlm: Demote incomplete kernel-doc header
fs: ecryptfs: read_write: File headers do not make good candidates for
kernel-doc
fs: ecryptfs: debug: Demote a couple of kernel-doc abuses
fs: ecryptfs: dentry: File headers are not good candidates for
kernel-doc
fs: ecryptfs: kthread: Demote file header and provide description for
'cred'
fs: ecryptfs: file: Demote kernel-doc abuses
fs: ecryptfs: super: Fix formatting, naming and kernel-doc abuses
fs: ecryptfs: messaging: Add missing param descriptions and demote
abuses
fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc
headers
fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates
fs: ecryptfs: crypto: Supply some missing param descriptions and
demote abuses
fs: ecryptfs: mmap: Help out one function header and demote other
abuses
fs: ecryptfs: inode: Help out nearly-there header and demote
non-conformant ones
fs: ecryptfs: keystore: Fix some kernel-doc issues and demote
non-conformant headers
fs/ecryptfs/crypto.c | 20 ++++++++++----------
fs/ecryptfs/debug.c | 4 ++--
fs/ecryptfs/dentry.c | 2 +-
fs/ecryptfs/file.c | 4 ++--
fs/ecryptfs/inode.c | 11 +++++------
fs/ecryptfs/keystore.c | 13 +++++++------
fs/ecryptfs/kthread.c | 3 ++-
fs/ecryptfs/main.c | 20 +++++++++-----------
fs/ecryptfs/messaging.c | 8 +++++---
fs/ecryptfs/miscdev.c | 3 ++-
fs/ecryptfs/mmap.c | 11 ++++++-----
fs/ecryptfs/read_write.c | 4 +++-
fs/ecryptfs/super.c | 8 ++++----
fs/gfs2/aops.c | 5 +----
fs/gfs2/bmap.c | 4 ++--
fs/gfs2/dir.c | 35 +++++++++++++----------------------
fs/gfs2/file.c | 3 +--
fs/gfs2/glock.c | 9 ++++-----
fs/gfs2/glops.c | 18 ++++++------------
fs/gfs2/inode.c | 22 ++++++++++++----------
fs/gfs2/lock_dlm.c | 3 +--
fs/gfs2/log.c | 11 ++++-------
fs/gfs2/lops.c | 13 +++++++------
fs/gfs2/meta_io.c | 1 +
fs/gfs2/ops_fstype.c | 7 ++-----
fs/gfs2/quota.c | 2 +-
fs/gfs2/recovery.c | 3 ++-
fs/gfs2/rgrp.c | 4 +++-
fs/gfs2/super.c | 13 ++++++-------
fs/gfs2/util.c | 19 ++++++++++---------
fs/gfs2/xattr.c | 25 +++++++------------------
31 files changed, 141 insertions(+), 167 deletions(-)
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Cc: cluster-devel@redhat.com
Cc: David Howells <dhowells@redhat.com>
Cc: ecryptfs@vger.kernel.org
Cc: Eric Biggers <ebiggers@google.com>
Cc: James Morris <jamorris@linux.microsoft.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: "Michael A. Halcrow" <mhalcrow@us.ibm.com>
Cc: "Michael C. Thompsion" <mcthomps@us.ibm.com>
Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Trevor S. Highland" <trevor.highland@gmail.com>
Cc: Tycho Andersen <tycho@tycho.pizza>
Cc: Tyler Hicks <code@tyhicks.com>
Cc: Waiman Long <longman@redhat.com>
--
2.27.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 20/31] fs: ecryptfs: debug: Demote a couple of kernel-doc abuses Lee Jones
` (12 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow, ecryptfs
Provide missing param description for 'page_index' too.
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/read_write.c:16: warning: Incorrect use of kernel-doc format: * ecryptfs_write_lower
fs/ecryptfs/read_write.c:29: warning: Function parameter or member 'ecryptfs_inode' not described in 'ecryptfs_write_lower'
fs/ecryptfs/read_write.c:29: warning: Function parameter or member 'data' not described in 'ecryptfs_write_lower'
fs/ecryptfs/read_write.c:29: warning: Function parameter or member 'offset' not described in 'ecryptfs_write_lower'
fs/ecryptfs/read_write.c:29: warning: Function parameter or member 'size' not described in 'ecryptfs_write_lower'
fs/ecryptfs/read_write.c:29: warning: expecting prototype for eCryptfs(). Prototype was for ecryptfs_write_lower() instead
fs/ecryptfs/read_write.c:248: warning: Function parameter or member 'page_index' not described in 'ecryptfs_read_lower_page_segment'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/read_write.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/ecryptfs/read_write.c b/fs/ecryptfs/read_write.c
index 0438997ac9d87..60bdcaddcbe57 100644
--- a/fs/ecryptfs/read_write.c
+++ b/fs/ecryptfs/read_write.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 2007 International Business Machines Corp.
@@ -230,6 +230,8 @@ int ecryptfs_read_lower(char *data, loff_t offset, size_t size,
* ecryptfs_read_lower_page_segment
* @page_for_ecryptfs: The page into which data for eCryptfs will be
* written
+ * @page_index: Page index in @page_for_ecryptfs from which to start
+ * writing
* @offset_in_page: Offset in @page_for_ecryptfs from which to start
* writing
* @size: The number of bytes to write into @page_for_ecryptfs
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 20/31] fs: ecryptfs: debug: Demote a couple of kernel-doc abuses
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
2021-03-30 16:44 ` [PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 21/31] fs: ecryptfs: dentry: File headers are not good candidates for kernel-doc Lee Jones
` (11 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/debug.c:13: warning: Incorrect use of kernel-doc format: * ecryptfs_dump_auth_tok - debug function to print auth toks
fs/ecryptfs/debug.c:19: warning: Function parameter or member 'auth_tok' not described in 'ecryptfs_dump_auth_tok'
fs/ecryptfs/debug.c:19: warning: expecting prototype for eCryptfs(). Prototype was for ecryptfs_dump_auth_tok() instead
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ecryptfs/debug.c b/fs/ecryptfs/debug.c
index 1f65e99f9a414..cf6d0e8e25a16 100644
--- a/fs/ecryptfs/debug.c
+++ b/fs/ecryptfs/debug.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
* Functions only useful for debugging.
*
@@ -9,7 +9,7 @@
#include "ecryptfs_kernel.h"
-/**
+/*
* ecryptfs_dump_auth_tok - debug function to print auth toks
*
* This function will print the contents of an ecryptfs authentication
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 21/31] fs: ecryptfs: dentry: File headers are not good candidates for kernel-doc
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
2021-03-30 16:44 ` [PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc Lee Jones
2021-03-30 16:44 ` [PATCH 20/31] fs: ecryptfs: debug: Demote a couple of kernel-doc abuses Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 22/31] fs: ecryptfs: kthread: Demote file header and provide description for 'cred' Lee Jones
` (10 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/dentry.c:19: warning: Incorrect use of kernel-doc format: * ecryptfs_d_revalidate - revalidate an ecryptfs dentry
fs/ecryptfs/dentry.c:32: warning: Function parameter or member 'dentry' not described in 'ecryptfs_d_revalidate'
fs/ecryptfs/dentry.c:32: warning: Function parameter or member 'flags' not described in 'ecryptfs_d_revalidate'
fs/ecryptfs/dentry.c:32: warning: expecting prototype for eCryptfs(). Prototype was for ecryptfs_d_revalidate() instead
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/dentry.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c
index 44606f079efb0..acaa0825e9bbe 100644
--- a/fs/ecryptfs/dentry.c
+++ b/fs/ecryptfs/dentry.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 1997-2003 Erez Zadok
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 22/31] fs: ecryptfs: kthread: Demote file header and provide description for 'cred'
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (2 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 21/31] fs: ecryptfs: dentry: File headers are not good candidates for kernel-doc Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 23/31] fs: ecryptfs: file: Demote kernel-doc abuses Lee Jones
` (9 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/kthread.c:16: warning: cannot understand function prototype: 'struct ecryptfs_open_req '
fs/ecryptfs/kthread.c:120: warning: Function parameter or member 'cred' not described in 'ecryptfs_privileged_open'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/kthread.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ecryptfs/kthread.c b/fs/ecryptfs/kthread.c
index a7c903cb01a05..ae4cb4e2e1348 100644
--- a/fs/ecryptfs/kthread.c
+++ b/fs/ecryptfs/kthread.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 2008 International Business Machines Corp.
@@ -108,6 +108,7 @@ void ecryptfs_destroy_kthread(void)
* @lower_file: Result of dentry_open by root on lower dentry
* @lower_dentry: Lower dentry for file to open
* @lower_mnt: Lower vfsmount for file to open
+ * @cred: credential to use for this call
*
* This function gets a r/w file opened against the lower dentry.
*
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 23/31] fs: ecryptfs: file: Demote kernel-doc abuses
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (3 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 22/31] fs: ecryptfs: kthread: Demote file header and provide description for 'cred' Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 24/31] fs: ecryptfs: super: Fix formatting, naming and " Lee Jones
` (8 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow,
Michael C. Thompson, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/file.c:23: warning: Incorrect use of kernel-doc format: * ecryptfs_read_update_atime
fs/ecryptfs/file.c:34: warning: Function parameter or member 'iocb' not described in 'ecryptfs_read_update_atime'
fs/ecryptfs/file.c:34: warning: Function parameter or member 'to' not described in 'ecryptfs_read_update_atime'
fs/ecryptfs/file.c:34: warning: expecting prototype for eCryptfs(). Prototype was for ecryptfs_read_update_atime() instead
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mhalcrow@us.ibm.com>
Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c
index 5fb45d865ce51..18d5b91cb573e 100644
--- a/fs/ecryptfs/file.c
+++ b/fs/ecryptfs/file.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 1997-2004 Erez Zadok
@@ -19,7 +19,7 @@
#include <linux/fs_stack.h>
#include "ecryptfs_kernel.h"
-/**
+/*
* ecryptfs_read_update_atime
*
* generic_file_read updates the atime of upper layer inode. But, it
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 24/31] fs: ecryptfs: super: Fix formatting, naming and kernel-doc abuses
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (4 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 23/31] fs: ecryptfs: file: Demote kernel-doc abuses Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 25/31] fs: ecryptfs: messaging: Add missing param descriptions and demote abuses Lee Jones
` (7 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow,
Michael C. Thompson, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/super.c:22: warning: cannot understand function prototype: 'struct kmem_cache *ecryptfs_inode_info_cache; '
fs/ecryptfs/super.c:91: warning: Function parameter or member 'dentry' not described in 'ecryptfs_statfs'
fs/ecryptfs/super.c:91: warning: Excess function parameter 'sb' description in 'ecryptfs_statfs'
fs/ecryptfs/super.c:120: warning: Function parameter or member 'inode' not described in 'ecryptfs_evict_inode'
fs/ecryptfs/super.c:133: warning: Function parameter or member 'm' not described in 'ecryptfs_show_options'
fs/ecryptfs/super.c:133: warning: Function parameter or member 'root' not described in 'ecryptfs_show_options'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/super.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ecryptfs/super.c b/fs/ecryptfs/super.c
index 6b1853f1c06a9..39116af0390f7 100644
--- a/fs/ecryptfs/super.c
+++ b/fs/ecryptfs/super.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 1997-2003 Erez Zadok
@@ -81,7 +81,7 @@ static void ecryptfs_destroy_inode(struct inode *inode)
/**
* ecryptfs_statfs
- * @sb: The ecryptfs super block
+ * @dentry: The ecryptfs dentry
* @buf: The struct kstatfs to fill in with stats
*
* Get the filesystem statistics. Currently, we let this pass right through
@@ -108,7 +108,7 @@ static int ecryptfs_statfs(struct dentry *dentry, struct kstatfs *buf)
/**
* ecryptfs_evict_inode
- * @inode - The ecryptfs inode
+ * @inode: The ecryptfs inode
*
* Called by iput() when the inode reference count reached zero
* and the inode is not hashed anywhere. Used to clear anything
@@ -123,7 +123,7 @@ static void ecryptfs_evict_inode(struct inode *inode)
iput(ecryptfs_inode_to_lower(inode));
}
-/**
+/*
* ecryptfs_show_options
*
* Prints the mount options for a given superblock.
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 25/31] fs: ecryptfs: messaging: Add missing param descriptions and demote abuses
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (5 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 24/31] fs: ecryptfs: super: Fix formatting, naming and " Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers Lee Jones
` (6 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, David Howells, Johannes Weiner,
Waiman Long, Michal Hocko, Andrew Morton, Michael A. Halcrow,
ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/messaging.c:15: warning: Function parameter or member 'ecryptfs_msg_ctx_free_list' not described in 'LIST_HEAD'
fs/ecryptfs/messaging.c:15: warning: expecting prototype for eCryptfs(). Prototype was for LIST_HEAD() instead
fs/ecryptfs/messaging.c:157: warning: Function parameter or member 'daemon' not described in 'ecryptfs_exorcise_daemon'
fs/ecryptfs/messaging.c:207: warning: Function parameter or member 'daemon' not described in 'ecryptfs_process_response'
fs/ecryptfs/messaging.c:207: warning: expecting prototype for ecryptfs_process_reponse(). Prototype was for ecryptfs_process_response() instead
fs/ecryptfs/messaging.c:262: warning: Function parameter or member 'msg_type' not described in 'ecryptfs_send_message_locked'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Michael A. Halcrow" <mhalcrow@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/messaging.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
index c0dfd9647627a..b38bd742fd973 100644
--- a/fs/ecryptfs/messaging.c
+++ b/fs/ecryptfs/messaging.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 2004-2008 International Business Machines Corp.
@@ -147,7 +147,7 @@ ecryptfs_spawn_daemon(struct ecryptfs_daemon **daemon, struct file *file)
return rc;
}
-/**
+/*
* ecryptfs_exorcise_daemon - Destroy the daemon struct
*
* Must be called ceremoniously while in possession of
@@ -181,7 +181,8 @@ int ecryptfs_exorcise_daemon(struct ecryptfs_daemon *daemon)
}
/**
- * ecryptfs_process_reponse
+ * ecryptfs_process_response
+ * @daemon: eCryptfs daemon object
* @msg: The ecryptfs message received; the caller should sanity check
* msg->data_len and free the memory
* @seq: The sequence number of the message; must match the sequence
@@ -250,6 +251,7 @@ int ecryptfs_process_response(struct ecryptfs_daemon *daemon,
* ecryptfs_send_message_locked
* @data: The data to send
* @data_len: The length of data
+ * @msg_type: Type of message
* @msg_ctx: The message context allocated for the send
*
* Must be called with ecryptfs_daemon_hash_mux held.
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (6 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 25/31] fs: ecryptfs: messaging: Add missing param descriptions and demote abuses Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-04-18 17:19 ` Tyler Hicks
2021-03-30 16:44 ` [PATCH 27/31] fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates Lee Jones
` (5 subsequent siblings)
13 siblings, 1 reply; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, Christian Brauner, James Morris,
Michael A. Halcrow, Michael C. Thompson, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/main.c:28: warning: Incorrect use of kernel-doc format: * Module parameter that defines the ecryptfs_verbosity level.
fs/ecryptfs/main.c:30: warning: cannot understand function prototype: 'int ecryptfs_verbosity = 0; '
fs/ecryptfs/main.c:40: warning: cannot understand function prototype: 'unsigned int ecryptfs_message_buf_len = ECRYPTFS_DEFAULT_MSG_CTX_ELEMS; '
fs/ecryptfs/main.c:52: warning: cannot understand function prototype: 'signed long ecryptfs_message_wait_timeout = ECRYPTFS_MAX_MSG_CTX_TTL / HZ; '
fs/ecryptfs/main.c:65: warning: cannot understand function prototype: 'unsigned int ecryptfs_number_of_users = ECRYPTFS_DEFAULT_NUM_USERS; '
fs/ecryptfs/main.c:106: warning: Function parameter or member 'dentry' not described in 'ecryptfs_init_lower_file'
fs/ecryptfs/main.c:106: warning: Function parameter or member 'lower_file' not described in 'ecryptfs_init_lower_file'
fs/ecryptfs/main.c:106: warning: Excess function parameter 'ecryptfs_dentry' description in 'ecryptfs_init_lower_file'
fs/ecryptfs/main.c:244: warning: Function parameter or member 'sbi' not described in 'ecryptfs_parse_options'
fs/ecryptfs/main.c:244: warning: Excess function parameter 'sb' description in 'ecryptfs_parse_options'
fs/ecryptfs/main.c:478: warning: Function parameter or member 'fs_type' not described in 'ecryptfs_mount'
fs/ecryptfs/main.c:478: warning: Function parameter or member 'flags' not described in 'ecryptfs_mount'
fs/ecryptfs/main.c:478: warning: expecting prototype for ecryptfs_get_sb(). Prototype was for ecryptfs_mount() instead
fs/ecryptfs/main.c:645: warning: Function parameter or member 'vptr' not described in 'inode_info_init_once'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Cc: James Morris <jamorris@linux.microsoft.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/main.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index cdf40a54a35d8..0a6ef2472f205 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 1997-2003 Erez Zadok
@@ -24,7 +24,7 @@
#include <linux/magic.h>
#include "ecryptfs_kernel.h"
-/**
+/*
* Module parameter that defines the ecryptfs_verbosity level.
*/
int ecryptfs_verbosity = 0;
@@ -34,7 +34,7 @@ MODULE_PARM_DESC(ecryptfs_verbosity,
"Initial verbosity level (0 or 1; defaults to "
"0, which is Quiet)");
-/**
+/*
* Module parameter that defines the number of message buffer elements
*/
unsigned int ecryptfs_message_buf_len = ECRYPTFS_DEFAULT_MSG_CTX_ELEMS;
@@ -43,7 +43,7 @@ module_param(ecryptfs_message_buf_len, uint, 0);
MODULE_PARM_DESC(ecryptfs_message_buf_len,
"Number of message buffer elements");
-/**
+/*
* Module parameter that defines the maximum guaranteed amount of time to wait
* for a response from ecryptfsd. The actual sleep time will be, more than
* likely, a small amount greater than this specified value, but only less if
@@ -57,7 +57,7 @@ MODULE_PARM_DESC(ecryptfs_message_wait_timeout,
"sleep while waiting for a message response from "
"userspace");
-/**
+/*
* Module parameter that is an estimate of the maximum number of users
* that will be concurrently using eCryptfs. Set this to the right
* value to balance performance and memory use.
@@ -80,7 +80,7 @@ void __ecryptfs_printk(const char *fmt, ...)
va_end(args);
}
-/**
+/*
* ecryptfs_init_lower_file
* @ecryptfs_dentry: Fully initialized eCryptfs dentry object, with
* the lower dentry and the lower mount set
@@ -221,7 +221,7 @@ static void ecryptfs_init_mount_crypt_stat(
/**
* ecryptfs_parse_options
- * @sb: The ecryptfs super block
+ * @sbi: The ecryptfs super block
* @options: The options passed to the kernel
* @check_ruid: set to 1 if device uid should be checked against the ruid
*
@@ -466,10 +466,8 @@ static int ecryptfs_parse_options(struct ecryptfs_sb_info *sbi, char *options,
struct kmem_cache *ecryptfs_sb_info_cache;
static struct file_system_type ecryptfs_fs_type;
-/**
+/*
* ecryptfs_get_sb
- * @fs_type
- * @flags
* @dev_name: The path to mount over
* @raw_data: The options passed into the kernel
*/
@@ -635,7 +633,7 @@ static struct file_system_type ecryptfs_fs_type = {
};
MODULE_ALIAS_FS("ecryptfs");
-/**
+/*
* inode_info_init_once
*
* Initializes the ecryptfs_inode_info_cache when it is created
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 27/31] fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (7 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses Lee Jones
` (4 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow, ecryptfs
Supply description for the 'daemon' param too.
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/miscdev.c:19: warning: cannot understand function prototype: 'atomic_t ecryptfs_num_miscdev_opens; '
fs/ecryptfs/miscdev.c:323: warning: Function parameter or member 'daemon' not described in 'ecryptfs_miscdev_response'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mhalcrow@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/miscdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ecryptfs/miscdev.c b/fs/ecryptfs/miscdev.c
index 742ece22c1d43..4e62c3cef70fb 100644
--- a/fs/ecryptfs/miscdev.c
+++ b/fs/ecryptfs/miscdev.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 2008 International Business Machines Corp.
@@ -312,6 +312,7 @@ ecryptfs_miscdev_read(struct file *file, char __user *buf, size_t count,
/**
* ecryptfs_miscdev_response - miscdevess response to message previously sent to daemon
+ * @daemon: eCryptfs daemon object
* @data: Bytes comprising struct ecryptfs_message
* @data_size: sizeof(struct ecryptfs_message) + data len
* @seq: Sequence number for miscdev response packet
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (8 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 27/31] fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-04-18 17:17 ` Tyler Hicks
2021-03-30 16:44 ` [PATCH 29/31] fs: ecryptfs: mmap: Help out one function header and demote other abuses Lee Jones
` (3 subsequent siblings)
13 siblings, 1 reply; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, Eric Biggers, Michael A. Halcrow,
Michael C. Thompson, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/crypto.c:29: warning: expecting prototype for eCryptfs(). Prototype was for DECRYPT() instead
fs/ecryptfs/crypto.c:360: warning: Function parameter or member 'crypt_stat' not described in 'lower_offset_for_page'
fs/ecryptfs/crypto.c:360: warning: Function parameter or member 'page' not described in 'lower_offset_for_page'
fs/ecryptfs/crypto.c:637: warning: Function parameter or member 'crypt_stat' not described in 'ecryptfs_compute_root_iv'
fs/ecryptfs/crypto.c:1386: warning: Function parameter or member 'ecryptfs_dentry' not described in 'ecryptfs_read_metadata'
fs/ecryptfs/crypto.c:1463: warning: Function parameter or member 'filename' not described in 'ecryptfs_encrypt_filename'
fs/ecryptfs/crypto.c:1463: warning: Function parameter or member 'mount_crypt_stat' not described in 'ecryptfs_encrypt_filename'
fs/ecryptfs/crypto.c:1897: warning: Function parameter or member 'encoded_name_size' not described in 'ecryptfs_encrypt_and_encode_filename'
fs/ecryptfs/crypto.c:1897: warning: Function parameter or member 'mount_crypt_stat' not described in 'ecryptfs_encrypt_and_encode_filename'
fs/ecryptfs/crypto.c:1897: warning: Function parameter or member 'name_size' not described in 'ecryptfs_encrypt_and_encode_filename'
fs/ecryptfs/crypto.c:1897: warning: Excess function parameter 'crypt_stat' description in 'ecryptfs_encrypt_and_encode_filename'
fs/ecryptfs/crypto.c:1897: warning: Excess function parameter 'length' description in 'ecryptfs_encrypt_and_encode_filename'
fs/ecryptfs/crypto.c:2006: warning: Function parameter or member 'sb' not described in 'ecryptfs_decode_and_decrypt_filename'
fs/ecryptfs/crypto.c:2006: warning: Excess function parameter 'ecryptfs_dir_dentry' description in 'ecryptfs_decode_and_decrypt_filename'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: Eric Biggers <ebiggers@google.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/crypto.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
index 7671412b8f0b4..cdcbcf7b5b6c7 100644
--- a/fs/ecryptfs/crypto.c
+++ b/fs/ecryptfs/crypto.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 1997-2004 Erez Zadok
@@ -350,7 +350,7 @@ static int crypt_scatterlist(struct ecryptfs_crypt_stat *crypt_stat,
return rc;
}
-/**
+/*
* lower_offset_for_page
*
* Convert an eCryptfs page index into a lower byte offset
@@ -627,9 +627,8 @@ void ecryptfs_set_default_sizes(struct ecryptfs_crypt_stat *crypt_stat)
}
}
-/**
+/*
* ecryptfs_compute_root_iv
- * @crypt_stats
*
* On error, sets the root IV to all 0's.
*/
@@ -1370,7 +1369,7 @@ int ecryptfs_read_and_validate_xattr_region(struct dentry *dentry,
return rc;
}
-/**
+/*
* ecryptfs_read_metadata
*
* Common entry point for reading file metadata. From here, we could
@@ -1448,7 +1447,7 @@ int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry)
return rc;
}
-/**
+/*
* ecryptfs_encrypt_filename - encrypt filename
*
* CBC-encrypts the filename. We do not want to encrypt the same
@@ -1876,10 +1875,11 @@ ecryptfs_decode_from_filename(unsigned char *dst, size_t *dst_size,
/**
* ecryptfs_encrypt_and_encode_filename - converts a plaintext file name to cipher text
- * @crypt_stat: The crypt_stat struct associated with the file anem to encode
+ * @encoded_name: The encrypted name
+ * @encoded_name_size: Length of the encrypted name
+ * @mount_crypt_stat: The crypt_stat struct associated with the file anem to encode
* @name: The plaintext name
- * @length: The length of the plaintext
- * @encoded_name: The encypted name
+ * @name_size: The length of the plaintext name
*
* Encrypts and encodes a filename into something that constitutes a
* valid filename for a filesystem, with printable characters.
@@ -1991,7 +1991,7 @@ static bool is_dot_dotdot(const char *name, size_t name_size)
* ecryptfs_decode_and_decrypt_filename - converts the encoded cipher text name to decoded plaintext
* @plaintext_name: The plaintext name
* @plaintext_name_size: The plaintext name size
- * @ecryptfs_dir_dentry: eCryptfs directory dentry
+ * @sb: Ecryptfs's super_block
* @name: The filename in cipher text
* @name_size: The cipher text name size
*
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 29/31] fs: ecryptfs: mmap: Help out one function header and demote other abuses
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (9 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 30/31] fs: ecryptfs: inode: Help out nearly-there header and demote non-conformant ones Lee Jones
` (2 subsequent siblings)
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, James Morris, Tycho Andersen,
Christian Brauner, Michael A. Halcrow, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/mmap.c:26: warning: Incorrect use of kernel-doc format: * ecryptfs_get_locked_page
fs/ecryptfs/mmap.c:34: warning: Function parameter or member 'inode' not described in 'ecryptfs_get_locked_page'
fs/ecryptfs/mmap.c:34: warning: Function parameter or member 'index' not described in 'ecryptfs_get_locked_page'
fs/ecryptfs/mmap.c:34: warning: expecting prototype for eCryptfs(). Prototype was for ecryptfs_get_locked_page() instead
fs/ecryptfs/mmap.c:52: warning: Function parameter or member 'wbc' not described in 'ecryptfs_writepage'
fs/ecryptfs/mmap.c:98: warning: Incorrect use of kernel-doc format: * ecryptfs_copy_up_encrypted_with_header
fs/ecryptfs/mmap.c:110: warning: Function parameter or member 'page' not described in 'ecryptfs_copy_up_encrypted_with_header'
fs/ecryptfs/mmap.c:110: warning: Function parameter or member 'crypt_stat' not described in 'ecryptfs_copy_up_encrypted_with_header'
fs/ecryptfs/mmap.c:110: warning: expecting prototype for Header Extent(). Prototype was for ecryptfs_copy_up_encrypted_with_header() instead
fs/ecryptfs/mmap.c:233: warning: wrong kernel-doc identifier on line:
fs/ecryptfs/mmap.c:379: warning: Function parameter or member 'ecryptfs_inode' not described in 'ecryptfs_write_inode_size_to_header'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: James Morris <jamorris@linux.microsoft.com>
Cc: Tycho Andersen <tycho@tycho.pizza>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/mmap.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/fs/ecryptfs/mmap.c b/fs/ecryptfs/mmap.c
index 2f333a40ff4d9..392e721b50a3d 100644
--- a/fs/ecryptfs/mmap.c
+++ b/fs/ecryptfs/mmap.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
* This is where eCryptfs coordinates the symmetric encryption and
* decryption of the file data as it passes between the lower
@@ -22,7 +22,7 @@
#include <asm/unaligned.h>
#include "ecryptfs_kernel.h"
-/**
+/*
* ecryptfs_get_locked_page
*
* Get one page from cache or lower f/s, return error otherwise.
@@ -41,6 +41,7 @@ struct page *ecryptfs_get_locked_page(struct inode *inode, loff_t index)
/**
* ecryptfs_writepage
* @page: Page that is locked before this call is made
+ * @wbc: Write-back control structure
*
* Returns zero on success; non-zero otherwise
*
@@ -78,7 +79,7 @@ static void strip_xattr_flag(char *page_virt,
}
}
-/**
+/*
* Header Extent:
* Octets 0-7: Unencrypted file size (big-endian)
* Octets 8-15: eCryptfs special marker
@@ -229,7 +230,7 @@ static int ecryptfs_readpage(struct file *file, struct page *page)
return rc;
}
-/**
+/*
* Called with lower inode mutex held.
*/
static int fill_zeros_to_end_of_page(struct page *page, unsigned int to)
@@ -368,7 +369,7 @@ static int ecryptfs_write_begin(struct file *file,
return rc;
}
-/**
+/*
* ecryptfs_write_inode_size_to_header
*
* Writes the lower file size to the first 8 bytes of the header.
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 30/31] fs: ecryptfs: inode: Help out nearly-there header and demote non-conformant ones
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (10 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 29/31] fs: ecryptfs: mmap: Help out one function header and demote other abuses Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-03-30 16:44 ` [PATCH 31/31] fs: ecryptfs: keystore: Fix some kernel-doc issues and demote non-conformant headers Lee Jones
2021-04-19 5:09 ` [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Tyler Hicks
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow,
Michael C. Thompsion, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/inode.c:27: warning: Function parameter or member 'dentry' not described in 'lock_parent'
fs/ecryptfs/inode.c:27: warning: Function parameter or member 'lower_dentry' not described in 'lock_parent'
fs/ecryptfs/inode.c:27: warning: Function parameter or member 'lower_dir' not described in 'lock_parent'
fs/ecryptfs/inode.c:27: warning: expecting prototype for eCryptfs(). Prototype was for lock_parent() instead
fs/ecryptfs/inode.c:211: warning: Function parameter or member 'ecryptfs_dentry' not described in 'ecryptfs_initialize_file'
fs/ecryptfs/inode.c:211: warning: Function parameter or member 'ecryptfs_inode' not described in 'ecryptfs_initialize_file'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'mnt_userns' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'directory_inode' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'ecryptfs_dentry' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'excl' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Excess function parameter 'dir' description in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Excess function parameter 'dentry' description in 'ecryptfs_create'
fs/ecryptfs/inode.c:320: warning: Function parameter or member 'dentry' not described in 'ecryptfs_lookup_interpose'
fs/ecryptfs/inode.c:320: warning: Function parameter or member 'lower_dentry' not described in 'ecryptfs_lookup_interpose'
fs/ecryptfs/inode.c:887: warning: Function parameter or member 'mnt_userns' not described in 'ecryptfs_setattr'
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: "Michael C. Thompsion" <mcthomps@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/inode.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 861a01713f3f4..9ac527e498e16 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
*
* Copyright (C) 1997-2004 Erez Zadok
@@ -198,7 +198,7 @@ ecryptfs_do_create(struct inode *directory_inode,
return inode;
}
-/**
+/*
* ecryptfs_initialize_file
*
* Cause the file to be changed from a basic empty file to an ecryptfs
@@ -241,10 +241,8 @@ int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry,
return rc;
}
-/**
+/*
* ecryptfs_create
- * @dir: The inode of the directory in which to create the file.
- * @dentry: The eCryptfs dentry
* @mode: The mode of the new file.
*
* Creates a new file.
@@ -312,7 +310,7 @@ static int ecryptfs_i_size_read(struct dentry *dentry, struct inode *inode)
return 0;
}
-/**
+/*
* ecryptfs_lookup_interpose - Dentry interposition for a lookup
*/
static struct dentry *ecryptfs_lookup_interpose(struct dentry *dentry,
@@ -872,6 +870,7 @@ ecryptfs_permission(struct user_namespace *mnt_userns, struct inode *inode,
/**
* ecryptfs_setattr
+ * @mnt_userns: user namespace of the target mount
* @dentry: dentry handle to the inode to modify
* @ia: Structure with flags of what to change and values
*
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 31/31] fs: ecryptfs: keystore: Fix some kernel-doc issues and demote non-conformant headers
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (11 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 30/31] fs: ecryptfs: inode: Help out nearly-there header and demote non-conformant ones Lee Jones
@ 2021-03-30 16:44 ` Lee Jones
2021-04-19 5:09 ` [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Tyler Hicks
13 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-03-30 16:44 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tyler Hicks, Michael A. Halcrow,
Michael C. Thompson, Trevor S. Highland, ecryptfs
Fixes the following W=1 kernel build warning(s):
fs/ecryptfs/keystore.c:25: warning: Incorrect use of kernel-doc format: * request_key returned an error instead of a valid key address;
fs/ecryptfs/keystore.c:30: warning: Function parameter or member 'err_code' not described in 'process_request_key_err'
fs/ecryptfs/keystore.c:30: warning: expecting prototype for eCryptfs(). Prototype was for process_request_key_err() instead
fs/ecryptfs/keystore.c:558: warning: Function parameter or member 'auth_tok_key' not described in 'ecryptfs_find_auth_tok_for_sig'
fs/ecryptfs/keystore.c:558: warning: Function parameter or member 'mount_crypt_stat' not described in 'ecryptfs_find_auth_tok_for_sig'
fs/ecryptfs/keystore.c:558: warning: Excess function parameter 'crypt_stat' description in 'ecryptfs_find_auth_tok_for_sig'
fs/ecryptfs/keystore.c:584: warning: cannot understand function prototype: 'struct ecryptfs_write_tag_70_packet_silly_stack '
fs/ecryptfs/keystore.c:622: warning: Function parameter or member 'dest' not described in 'ecryptfs_write_tag_70_packet'
fs/ecryptfs/keystore.c:622: warning: Function parameter or member 'remaining_bytes' not described in 'ecryptfs_write_tag_70_packet'
fs/ecryptfs/keystore.c:622: warning: Function parameter or member 'packet_size' not described in 'ecryptfs_write_tag_70_packet'
fs/ecryptfs/keystore.c:622: warning: Function parameter or member 'mount_crypt_stat' not described in 'ecryptfs_write_tag_70_packet'
fs/ecryptfs/keystore.c:622: warning: Function parameter or member 'filename_size' not described in 'ecryptfs_write_tag_70_packet'
fs/ecryptfs/keystore.c:622: warning: expecting prototype for write_tag_70_packet(). Prototype was for ecryptfs_write_tag_70_packet() instead
fs/ecryptfs/keystore.c:895: warning: expecting prototype for parse_tag_70_packet(). Prototype was for ecryptfs_parse_tag_70_packet() instead
Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mhalcrow@us.ibm.com>
Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
Cc: "Trevor S. Highland" <trevor.highland@gmail.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/ecryptfs/keystore.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
index 2abd219cfeec6..3fe41964c0d8d 100644
--- a/fs/ecryptfs/keystore.c
+++ b/fs/ecryptfs/keystore.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* eCryptfs: Linux filesystem encryption layer
* In-kernel key management code. Includes functions to parse and
* write authentication token-related packets with the underlying
@@ -21,7 +21,7 @@
#include <linux/slab.h>
#include "ecryptfs_kernel.h"
-/**
+/*
* request_key returned an error instead of a valid key address;
* determine the type of error, make appropriate log entries, and
* return an error code.
@@ -536,8 +536,9 @@ ecryptfs_find_global_auth_tok_for_sig(
/**
* ecryptfs_find_auth_tok_for_sig
+ * @auth_tok_key: key containing the authentication token
* @auth_tok: Set to the matching auth_tok; NULL if not found
- * @crypt_stat: inode crypt_stat crypto context
+ * @mount_crypt_stat: inode crypt_stat crypto context
* @sig: Sig of auth_tok to find
*
* For now, this function simply looks at the registered auth_tok's
@@ -576,7 +577,7 @@ ecryptfs_find_auth_tok_for_sig(
return rc;
}
-/**
+/*
* write_tag_70_packet can gobble a lot of stack space. We stuff most
* of the function's parameters in a kmalloc'd struct to help reduce
* eCryptfs' overall stack usage.
@@ -604,7 +605,7 @@ struct ecryptfs_write_tag_70_packet_silly_stack {
struct shash_desc *hash_desc;
};
-/**
+/*
* write_tag_70_packet - Write encrypted filename (EFN) packet against FNEK
* @filename: NULL-terminated filename string
*
@@ -873,7 +874,7 @@ struct ecryptfs_parse_tag_70_packet_silly_stack {
};
/**
- * parse_tag_70_packet - Parse and process FNEK-encrypted passphrase packet
+ * ecryptfs_parse_tag_70_packet - Parse and process FNEK-encrypted passphrase packet
* @filename: This function kmalloc's the memory for the filename
* @filename_size: This function sets this to the amount of memory
* kmalloc'd for the filename
--
2.27.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses
2021-03-30 16:44 ` [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses Lee Jones
@ 2021-04-18 17:17 ` Tyler Hicks
0 siblings, 0 replies; 18+ messages in thread
From: Tyler Hicks @ 2021-04-18 17:17 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Eric Biggers, Michael A. Halcrow,
Michael C. Thompson, ecryptfs
On 2021-03-30 17:44:55, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> fs/ecryptfs/crypto.c:29: warning: expecting prototype for eCryptfs(). Prototype was for DECRYPT() instead
> fs/ecryptfs/crypto.c:360: warning: Function parameter or member 'crypt_stat' not described in 'lower_offset_for_page'
> fs/ecryptfs/crypto.c:360: warning: Function parameter or member 'page' not described in 'lower_offset_for_page'
> fs/ecryptfs/crypto.c:637: warning: Function parameter or member 'crypt_stat' not described in 'ecryptfs_compute_root_iv'
> fs/ecryptfs/crypto.c:1386: warning: Function parameter or member 'ecryptfs_dentry' not described in 'ecryptfs_read_metadata'
> fs/ecryptfs/crypto.c:1463: warning: Function parameter or member 'filename' not described in 'ecryptfs_encrypt_filename'
> fs/ecryptfs/crypto.c:1463: warning: Function parameter or member 'mount_crypt_stat' not described in 'ecryptfs_encrypt_filename'
> fs/ecryptfs/crypto.c:1897: warning: Function parameter or member 'encoded_name_size' not described in 'ecryptfs_encrypt_and_encode_filename'
> fs/ecryptfs/crypto.c:1897: warning: Function parameter or member 'mount_crypt_stat' not described in 'ecryptfs_encrypt_and_encode_filename'
> fs/ecryptfs/crypto.c:1897: warning: Function parameter or member 'name_size' not described in 'ecryptfs_encrypt_and_encode_filename'
> fs/ecryptfs/crypto.c:1897: warning: Excess function parameter 'crypt_stat' description in 'ecryptfs_encrypt_and_encode_filename'
> fs/ecryptfs/crypto.c:1897: warning: Excess function parameter 'length' description in 'ecryptfs_encrypt_and_encode_filename'
> fs/ecryptfs/crypto.c:2006: warning: Function parameter or member 'sb' not described in 'ecryptfs_decode_and_decrypt_filename'
> fs/ecryptfs/crypto.c:2006: warning: Excess function parameter 'ecryptfs_dir_dentry' description in 'ecryptfs_decode_and_decrypt_filename'
>
> Cc: Tyler Hicks <code@tyhicks.com>
> Cc: Eric Biggers <ebiggers@google.com>
> Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
> Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
> Cc: ecryptfs@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> fs/ecryptfs/crypto.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
> index 7671412b8f0b4..cdcbcf7b5b6c7 100644
> --- a/fs/ecryptfs/crypto.c
> +++ b/fs/ecryptfs/crypto.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> -/**
> +/*
> * eCryptfs: Linux filesystem encryption layer
> *
> * Copyright (C) 1997-2004 Erez Zadok
> @@ -350,7 +350,7 @@ static int crypt_scatterlist(struct ecryptfs_crypt_stat *crypt_stat,
> return rc;
> }
>
> -/**
> +/*
> * lower_offset_for_page
> *
> * Convert an eCryptfs page index into a lower byte offset
> @@ -627,9 +627,8 @@ void ecryptfs_set_default_sizes(struct ecryptfs_crypt_stat *crypt_stat)
> }
> }
>
> -/**
> +/*
> * ecryptfs_compute_root_iv
> - * @crypt_stats
> *
> * On error, sets the root IV to all 0's.
> */
> @@ -1370,7 +1369,7 @@ int ecryptfs_read_and_validate_xattr_region(struct dentry *dentry,
> return rc;
> }
>
> -/**
> +/*
> * ecryptfs_read_metadata
> *
> * Common entry point for reading file metadata. From here, we could
> @@ -1448,7 +1447,7 @@ int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry)
> return rc;
> }
>
> -/**
> +/*
> * ecryptfs_encrypt_filename - encrypt filename
> *
> * CBC-encrypts the filename. We do not want to encrypt the same
> @@ -1876,10 +1875,11 @@ ecryptfs_decode_from_filename(unsigned char *dst, size_t *dst_size,
>
> /**
> * ecryptfs_encrypt_and_encode_filename - converts a plaintext file name to cipher text
> - * @crypt_stat: The crypt_stat struct associated with the file anem to encode
> + * @encoded_name: The encrypted name
> + * @encoded_name_size: Length of the encrypted name
> + * @mount_crypt_stat: The crypt_stat struct associated with the file anem to encode
s/anem/name/
I'll fix this up when applying.
Tyler
> * @name: The plaintext name
> - * @length: The length of the plaintext
> - * @encoded_name: The encypted name
> + * @name_size: The length of the plaintext name
> *
> * Encrypts and encodes a filename into something that constitutes a
> * valid filename for a filesystem, with printable characters.
> @@ -1991,7 +1991,7 @@ static bool is_dot_dotdot(const char *name, size_t name_size)
> * ecryptfs_decode_and_decrypt_filename - converts the encoded cipher text name to decoded plaintext
> * @plaintext_name: The plaintext name
> * @plaintext_name_size: The plaintext name size
> - * @ecryptfs_dir_dentry: eCryptfs directory dentry
> + * @sb: Ecryptfs's super_block
> * @name: The filename in cipher text
> * @name_size: The cipher text name size
> *
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers
2021-03-30 16:44 ` [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers Lee Jones
@ 2021-04-18 17:19 ` Tyler Hicks
0 siblings, 0 replies; 18+ messages in thread
From: Tyler Hicks @ 2021-04-18 17:19 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Christian Brauner, James Morris,
Michael A. Halcrow, Michael C. Thompson, ecryptfs
On 2021-03-30 17:44:53, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> fs/ecryptfs/main.c:28: warning: Incorrect use of kernel-doc format: * Module parameter that defines the ecryptfs_verbosity level.
> fs/ecryptfs/main.c:30: warning: cannot understand function prototype: 'int ecryptfs_verbosity = 0; '
> fs/ecryptfs/main.c:40: warning: cannot understand function prototype: 'unsigned int ecryptfs_message_buf_len = ECRYPTFS_DEFAULT_MSG_CTX_ELEMS; '
> fs/ecryptfs/main.c:52: warning: cannot understand function prototype: 'signed long ecryptfs_message_wait_timeout = ECRYPTFS_MAX_MSG_CTX_TTL / HZ; '
> fs/ecryptfs/main.c:65: warning: cannot understand function prototype: 'unsigned int ecryptfs_number_of_users = ECRYPTFS_DEFAULT_NUM_USERS; '
> fs/ecryptfs/main.c:106: warning: Function parameter or member 'dentry' not described in 'ecryptfs_init_lower_file'
> fs/ecryptfs/main.c:106: warning: Function parameter or member 'lower_file' not described in 'ecryptfs_init_lower_file'
> fs/ecryptfs/main.c:106: warning: Excess function parameter 'ecryptfs_dentry' description in 'ecryptfs_init_lower_file'
> fs/ecryptfs/main.c:244: warning: Function parameter or member 'sbi' not described in 'ecryptfs_parse_options'
> fs/ecryptfs/main.c:244: warning: Excess function parameter 'sb' description in 'ecryptfs_parse_options'
> fs/ecryptfs/main.c:478: warning: Function parameter or member 'fs_type' not described in 'ecryptfs_mount'
> fs/ecryptfs/main.c:478: warning: Function parameter or member 'flags' not described in 'ecryptfs_mount'
> fs/ecryptfs/main.c:478: warning: expecting prototype for ecryptfs_get_sb(). Prototype was for ecryptfs_mount() instead
> fs/ecryptfs/main.c:645: warning: Function parameter or member 'vptr' not described in 'inode_info_init_once'
>
> Cc: Tyler Hicks <code@tyhicks.com>
> Cc: Christian Brauner <christian.brauner@ubuntu.com>
> Cc: James Morris <jamorris@linux.microsoft.com>
> Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
> Cc: "Michael C. Thompson" <mcthomps@us.ibm.com>
> Cc: ecryptfs@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> fs/ecryptfs/main.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index cdf40a54a35d8..0a6ef2472f205 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> -/**
> +/*
> * eCryptfs: Linux filesystem encryption layer
> *
> * Copyright (C) 1997-2003 Erez Zadok
> @@ -24,7 +24,7 @@
> #include <linux/magic.h>
> #include "ecryptfs_kernel.h"
>
> -/**
> +/*
> * Module parameter that defines the ecryptfs_verbosity level.
> */
> int ecryptfs_verbosity = 0;
> @@ -34,7 +34,7 @@ MODULE_PARM_DESC(ecryptfs_verbosity,
> "Initial verbosity level (0 or 1; defaults to "
> "0, which is Quiet)");
>
> -/**
> +/*
> * Module parameter that defines the number of message buffer elements
> */
> unsigned int ecryptfs_message_buf_len = ECRYPTFS_DEFAULT_MSG_CTX_ELEMS;
> @@ -43,7 +43,7 @@ module_param(ecryptfs_message_buf_len, uint, 0);
> MODULE_PARM_DESC(ecryptfs_message_buf_len,
> "Number of message buffer elements");
>
> -/**
> +/*
> * Module parameter that defines the maximum guaranteed amount of time to wait
> * for a response from ecryptfsd. The actual sleep time will be, more than
> * likely, a small amount greater than this specified value, but only less if
> @@ -57,7 +57,7 @@ MODULE_PARM_DESC(ecryptfs_message_wait_timeout,
> "sleep while waiting for a message response from "
> "userspace");
>
> -/**
> +/*
> * Module parameter that is an estimate of the maximum number of users
> * that will be concurrently using eCryptfs. Set this to the right
> * value to balance performance and memory use.
> @@ -80,7 +80,7 @@ void __ecryptfs_printk(const char *fmt, ...)
> va_end(args);
> }
>
> -/**
> +/*
> * ecryptfs_init_lower_file
> * @ecryptfs_dentry: Fully initialized eCryptfs dentry object, with
> * the lower dentry and the lower mount set
> @@ -221,7 +221,7 @@ static void ecryptfs_init_mount_crypt_stat(
>
> /**
> * ecryptfs_parse_options
> - * @sb: The ecryptfs super block
> + * @sbi: The ecryptfs super block
> * @options: The options passed to the kernel
> * @check_ruid: set to 1 if device uid should be checked against the ruid
> *
> @@ -466,10 +466,8 @@ static int ecryptfs_parse_options(struct ecryptfs_sb_info *sbi, char *options,
> struct kmem_cache *ecryptfs_sb_info_cache;
> static struct file_system_type ecryptfs_fs_type;
>
> -/**
> +/*
> * ecryptfs_get_sb
> - * @fs_type
> - * @flags
This wasn't quite the right change. This function documentation block
was for ecryptfs_mount(). It was probably ecryptfs_get_sb() in the past
and the docs weren't updated. I've adjusted the function doc header and
added descriptions for @fs_type and @flags.
Tyler
> * @dev_name: The path to mount over
> * @raw_data: The options passed into the kernel
> */
> @@ -635,7 +633,7 @@ static struct file_system_type ecryptfs_fs_type = {
> };
> MODULE_ALIAS_FS("ecryptfs");
>
> -/**
> +/*
> * inode_info_init_once
> *
> * Initializes the ecryptfs_inode_info_cache when it is created
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
` (12 preceding siblings ...)
2021-03-30 16:44 ` [PATCH 31/31] fs: ecryptfs: keystore: Fix some kernel-doc issues and demote non-conformant headers Lee Jones
@ 2021-04-19 5:09 ` Tyler Hicks
2021-04-19 7:26 ` Lee Jones
13 siblings, 1 reply; 18+ messages in thread
From: Tyler Hicks @ 2021-04-19 5:09 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Andreas Gruenbacher, Andrew Morton, Bob Peterson,
Christian Brauner, cluster-devel, David Howells, ecryptfs,
Eric Biggers, James Morris, Johannes Weiner, Michael A. Halcrow,
Michael A. Halcrow, Michael C. Thompsion, Michal Hocko,
Trevor S. Highland, Tycho Andersen, Waiman Long
On 2021-03-30 17:44:27, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> There is more to do in filesystems. Another set will follow.
>
> Lee Jones (31):
...
> fs: ecryptfs: read_write: File headers do not make good candidates for
> kernel-doc
> fs: ecryptfs: debug: Demote a couple of kernel-doc abuses
> fs: ecryptfs: dentry: File headers are not good candidates for
> kernel-doc
> fs: ecryptfs: kthread: Demote file header and provide description for
> 'cred'
> fs: ecryptfs: file: Demote kernel-doc abuses
> fs: ecryptfs: super: Fix formatting, naming and kernel-doc abuses
> fs: ecryptfs: messaging: Add missing param descriptions and demote
> abuses
> fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc
> headers
> fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates
> fs: ecryptfs: crypto: Supply some missing param descriptions and
> demote abuses
> fs: ecryptfs: mmap: Help out one function header and demote other
> abuses
> fs: ecryptfs: inode: Help out nearly-there header and demote
> non-conformant ones
> fs: ecryptfs: keystore: Fix some kernel-doc issues and demote
> non-conformant headers
I've applied the eCryptfs fixes to the next branch of
tyhicks/ecryptfs.git. Thanks for the clean-up!
Tyler
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS
2021-04-19 5:09 ` [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Tyler Hicks
@ 2021-04-19 7:26 ` Lee Jones
0 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2021-04-19 7:26 UTC (permalink / raw)
To: Tyler Hicks
Cc: linux-kernel, Andreas Gruenbacher, Andrew Morton, Bob Peterson,
Christian Brauner, cluster-devel, David Howells, ecryptfs,
Eric Biggers, James Morris, Johannes Weiner, Michael A. Halcrow,
Michael A. Halcrow, Michael C. Thompsion, Michal Hocko,
Trevor S. Highland, Tycho Andersen, Waiman Long
On Mon, 19 Apr 2021, Tyler Hicks wrote:
> On 2021-03-30 17:44:27, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > There is more to do in filesystems. Another set will follow.
> >
> > Lee Jones (31):
> ...
> > fs: ecryptfs: read_write: File headers do not make good candidates for
> > kernel-doc
> > fs: ecryptfs: debug: Demote a couple of kernel-doc abuses
> > fs: ecryptfs: dentry: File headers are not good candidates for
> > kernel-doc
> > fs: ecryptfs: kthread: Demote file header and provide description for
> > 'cred'
> > fs: ecryptfs: file: Demote kernel-doc abuses
> > fs: ecryptfs: super: Fix formatting, naming and kernel-doc abuses
> > fs: ecryptfs: messaging: Add missing param descriptions and demote
> > abuses
> > fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc
> > headers
> > fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates
> > fs: ecryptfs: crypto: Supply some missing param descriptions and
> > demote abuses
> > fs: ecryptfs: mmap: Help out one function header and demote other
> > abuses
> > fs: ecryptfs: inode: Help out nearly-there header and demote
> > non-conformant ones
> > fs: ecryptfs: keystore: Fix some kernel-doc issues and demote
> > non-conformant headers
>
> I've applied the eCryptfs fixes to the next branch of
> tyhicks/ecryptfs.git. Thanks for the clean-up!
Thanks Tyler, much appreciated.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-04-19 7:27 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones
2021-03-30 16:44 ` [PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc Lee Jones
2021-03-30 16:44 ` [PATCH 20/31] fs: ecryptfs: debug: Demote a couple of kernel-doc abuses Lee Jones
2021-03-30 16:44 ` [PATCH 21/31] fs: ecryptfs: dentry: File headers are not good candidates for kernel-doc Lee Jones
2021-03-30 16:44 ` [PATCH 22/31] fs: ecryptfs: kthread: Demote file header and provide description for 'cred' Lee Jones
2021-03-30 16:44 ` [PATCH 23/31] fs: ecryptfs: file: Demote kernel-doc abuses Lee Jones
2021-03-30 16:44 ` [PATCH 24/31] fs: ecryptfs: super: Fix formatting, naming and " Lee Jones
2021-03-30 16:44 ` [PATCH 25/31] fs: ecryptfs: messaging: Add missing param descriptions and demote abuses Lee Jones
2021-03-30 16:44 ` [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers Lee Jones
2021-04-18 17:19 ` Tyler Hicks
2021-03-30 16:44 ` [PATCH 27/31] fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates Lee Jones
2021-03-30 16:44 ` [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses Lee Jones
2021-04-18 17:17 ` Tyler Hicks
2021-03-30 16:44 ` [PATCH 29/31] fs: ecryptfs: mmap: Help out one function header and demote other abuses Lee Jones
2021-03-30 16:44 ` [PATCH 30/31] fs: ecryptfs: inode: Help out nearly-there header and demote non-conformant ones Lee Jones
2021-03-30 16:44 ` [PATCH 31/31] fs: ecryptfs: keystore: Fix some kernel-doc issues and demote non-conformant headers Lee Jones
2021-04-19 5:09 ` [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Tyler Hicks
2021-04-19 7:26 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).