From: Al Viro <viro@zeniv.linux.org.uk>
To: Tyler Hicks <code@tyhicks.com>
Cc: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] ecryptfs: get rid of pointless dget/dput in ->symlink() and ->link()
Date: Sat, 20 Mar 2021 21:55:04 +0000 [thread overview]
Message-ID: <YFZvOLzj5eytBV/Q@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <YFZuSSpfWPrkJNVY@zeniv-ca.linux.org.uk>
On Sat, Mar 20, 2021 at 09:51:05PM +0000, Al Viro wrote:
> calls in ->unlink(), ->rmdir() and ->rename() make sense - we want
> to prevent the underlying dentries going negative there. In
> ->symlink() and ->link() they are absolutely pointless.
[snip]
FWIW, that patch series can also be found in
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.ecryptfs;
Shortlog:
Al Viro (4):
ecryptfs: get rid of pointless dget/dput in ->symlink() and ->link()
ecryptfs: saner API for lock_parent()
ecryptfs: get rid of unused accessors
ecryptfs: ecryptfs_dentry_info->crypt_stat is never used
Diffstat:
fs/ecryptfs/ecryptfs_kernel.h | 17 +----
fs/ecryptfs/inode.c | 163 +++++++++++++++++++-----------------------
2 files changed, 75 insertions(+), 105 deletions(-)
prev parent reply other threads:[~2021-03-20 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 21:51 [PATCH 1/4] ecryptfs: get rid of pointless dget/dput in ->symlink() and ->link() Al Viro
2021-03-20 21:51 ` [PATCH 2/4] ecryptfs: saner API for lock_parent() Al Viro
2021-03-20 21:52 ` [PATCH 3/4] ecryptfs: get rid of unused accessors Al Viro
2021-03-20 21:52 ` [PATCH 4/4] ecryptfs: ecryptfs_dentry_info->crypt_stat is never used Al Viro
2021-03-20 21:55 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFZvOLzj5eytBV/Q@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=code@tyhicks.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).