From: Like Xu <like.xu.linux@gmail.com>
To: Aaron Lewis <aaronlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH v6 0/7] Introduce and test masked events
Date: Wed, 9 Nov 2022 19:28:15 +0800 [thread overview]
Message-ID: <ed069cc3-bd0b-8d21-50b3-202e6e823ad2@gmail.com> (raw)
In-Reply-To: <Y1sAB0LlTPwnWjZp@google.com>
On 28/10/2022 6:02 am, Sean Christopherson wrote:
>> Aaron Lewis (7):
>> kvm: x86/pmu: Correct the mask used in a pmu event filter lookup
>> kvm: x86/pmu: Remove impossible events from the pmu event filter
>> kvm: x86/pmu: prepare the pmu event filter for masked events
>> kvm: x86/pmu: Introduce masked events to the pmu event filter
>> selftests: kvm/x86: Add flags when creating a pmu event filter
>> selftests: kvm/x86: Add testing for KVM_SET_PMU_EVENT_FILTER
>> selftests: kvm/x86: Test masked events
> One comment request in the last patch, but it's not the end of the world if it
> doesn't get added right away.
>
> An extra set of eyeballs from Paolo, Jim, and/or Like would be welcome as I don't
> consider myself trustworthy when it comes to PMU code...
>
> Reviewed-by: Sean Christopherson<seanjc@google.com>
>
I'm not going to block these changes just because I don't use the
pmu-event-filter feature very heavily.
One of my concern is the relatively lower test coverage of pmu-event-filter
involved code, despite its predictable performance optimizations.
Maybe a rebase version would attract more attention (or at least mine).
Thanks,
Like Xu
next prev parent reply other threads:[~2022-11-09 11:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 20:50 [PATCH v6 0/7] Introduce and test masked events Aaron Lewis
2022-10-21 20:50 ` [PATCH v6 1/7] kvm: x86/pmu: Correct the mask used in a pmu event filter lookup Aaron Lewis
2022-10-21 20:51 ` [PATCH v6 2/7] kvm: x86/pmu: Remove impossible events from the pmu event filter Aaron Lewis
2022-10-21 20:51 ` [PATCH v6 3/7] kvm: x86/pmu: prepare the pmu event filter for masked events Aaron Lewis
2022-10-21 20:51 ` [PATCH v6 4/7] kvm: x86/pmu: Introduce masked events to the pmu event filter Aaron Lewis
2022-12-15 9:43 ` Like Xu
2022-12-16 17:55 ` Sean Christopherson
2022-12-16 18:31 ` Aaron Lewis
2022-12-19 10:02 ` Like Xu
2022-10-21 20:51 ` [PATCH v6 5/7] selftests: kvm/x86: Add flags when creating a " Aaron Lewis
2022-10-21 20:51 ` [PATCH v6 6/7] selftests: kvm/x86: Add testing for KVM_SET_PMU_EVENT_FILTER Aaron Lewis
2022-10-21 20:51 ` [PATCH v6 7/7] selftests: kvm/x86: Test masked events Aaron Lewis
2022-10-27 22:00 ` Sean Christopherson
2022-10-27 22:02 ` [PATCH v6 0/7] Introduce and test " Sean Christopherson
2022-11-09 11:28 ` Like Xu [this message]
2022-11-09 17:41 ` Aaron Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed069cc3-bd0b-8d21-50b3-202e6e823ad2@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=aaronlewis@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.