Re: [Qemu-devel] [PATCH 13/14] tests/boot-serial: Add tests for PowerPC Mac machines

From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 13/14] tests/boot-serial: Add tests for PowerPC Mac machines
Date: Thu, 8 Feb 2018 16:41:34 -0600	[thread overview]
Message-ID: <ed70ae18-1864-63c6-ba5a-26cade9832e9@redhat.com> (raw)
In-Reply-To: <1518120582-26647-14-git-send-email-thuth@redhat.com>

On 02/08/2018 02:09 PM, Thomas Huth wrote:
> OpenBIOS prints out the CPU type on these machine types, so we can use
> this string to test whether the CPU detection is working correctly.
> 
> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/boot-serial-test.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index 996d3d7..72873ee 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -69,8 +69,11 @@ static testdef_t tests[] = {
>       { "alpha", "clipper", "", "PCI:" },
>       { "ppc", "ppce500", "", "U-Boot" },
>       { "ppc", "prep", "", "Open Hack'Ware BIOS" },
> +    { "ppc", "g3beige", "", "PowerPC,750" },
> +    { "ppc", "mac99", "", "PowerPC,G4" },
>       { "ppc64", "ppce500", "", "U-Boot" },
>       { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
> +    { "ppc64", "mac99", "", "PowerPC,970FX" },

[I wish thunderbird wouldn't corrupt whitespace when quoting patches - 
it seems to be a recent regression on something that used to work]

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org